From 91787a2003fe3d367a304ff66232b8b5cc2159a4 Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Fabian=20Gr=C3=BCnbichler?= Date: Mon, 3 Jul 2023 09:18:51 +0200 Subject: [PATCH] fix #4802: reduce CA lookups while proxying MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit OpenSSL as packaged in Debian bookworm now ships a compat symlink for the "combined" CA certificates file (CAfile) as managed by update-ca-certificates. This symlink is in addition to the CApath one that has been around for a file. The new symlink in turn gets picked up by openssl-using code that uses the default values for the trust store. Every TLS context initialization now reads the full combined file, even if no TLS is actually employed on a connection. We do such an initialization for every proxied connection (where our HTTP server is the client). By specifying an explicit CA path (that is identical to the default one), the old behaviour of looking up each CA certificate individually iff needed is enabled again. For an API endpoint where HTTP request handling is the bottle neck (as opposed to the actual API handler), this improves performance of proxied requests to be back in line with unproxied ones handled directly by the unprivileged daemon. For all proxied requests, CPU usage is decreased as well. The default CAfile and CApath contain the same certificates, so there should be no change in trusted certificates. Additionally, certificate fingerprints are pinned in this context and verified against the cache of pinned fingerprints. Reported-by: Roland Kletzing Signed-off-by: Fabian Grünbichler --- src/PVE/APIServer/AnyEvent.pm | 1 + 1 file changed, 1 insertion(+) diff --git a/src/PVE/APIServer/AnyEvent.pm b/src/PVE/APIServer/AnyEvent.pm index 8fb1a7a..e34c06a 100644 --- a/src/PVE/APIServer/AnyEvent.pm +++ b/src/PVE/APIServer/AnyEvent.pm @@ -766,6 +766,7 @@ sub proxy_request { sslv2 => 0, sslv3 => 0, verify => 1, + ca_path => '/usr/lib/ssl/certs', # to avoid loading the combined CA cert file verify_cb => sub { my (undef, undef, undef, $depth, undef, undef, $cert) = @_; # we don't care about intermediate or root certificates