proxmox-mirrors/pve-http-server
1
0
Fork 0
mirror of https://git.proxmox.com/git/pve-http-server synced 2025-05-02 16:20:13 +00:00
Code Issues Actions Packages Projects Releases Wiki Activity

WS: guard disconnect block check properly

Browse Source 
if the WS gets disconnected without any data having been sent first,
wbuf (and thus `length $wbuf`) is undef. the actual length of the buffer
is not relevant here anyway, just the fact that it's non-empty - so
avoid the undef warning by dropping the unnecessary comparison.

Signed-off-by: Fabian Grünbichler <f.gruenbichler@proxmox.com>
This commit is contained in:
Fabian Grünbichler 2021-12-17 10:55:34 +01:00
parent d298a22cc2
commit 6277311e71
1 changed files with 2 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

3
src/PVE/APIServer/AnyEvent.pm
View File

@ -636,7 +636,8 @@ sub websocket_proxy {
my $statuscode = unpack ("n", $payload); my $statuscode = unpack ("n", $payload);
$self->dprint("websocket received close. status code: '$statuscode'"); $self->dprint("websocket received close. status code: '$statuscode'");
if (my $proxyhdl = $reqstate->{proxyhdl}) { if (my $proxyhdl = $reqstate->{proxyhdl}) {
$proxyhdl->{block_disconnect} = 1 if length $proxyhdl->{wbuf} > 0; $proxyhdl->{block_disconnect} = 1 if length $proxyhdl->{wbuf};
$proxyhdl->push_shutdown(); $proxyhdl->push_shutdown();
} }
$hdl->push_shutdown(); $hdl->push_shutdown();