while this was much better than the old mess from
parse_pending_delete it still was a bit much nested into one line.
split that up a bit, add a render_key helper which does the clunky
"add !" check and just call that one in the map {}
Signed-off-by: Thomas Lamprecht <t.lamprecht@proxmox.com>
this was quite the mess, a perl greedy match over non-whitespace
character is equivalent to a split on whitespace on, but the latter
is much easier to grasp when looking at this the first time.
Do a real for loop with real variable names and less nest everything
into one line.
the test added in the previous commit should give use the safety net
for that cleanup.
Signed-off-by: Thomas Lamprecht <t.lamprecht@proxmox.com>
this code is already used by qemu-server's GET config API call. it is
however better to split this into to methods and decide what to run in
the API call.
this general implementation uses some $class helpers which allow to abstract
away the difference in the child classes. this will be used for
containers once they can do pending changes.
Signed-off-by: Oguz Bektas <o.bektas@proxmox.com>
use a better naming scheme for methods from qemuserver:
split_flagged_list -> parse_pending_delete
join_flagged_list -> print_pending_delete
vmconfig_delete_pending_option -> add_to_pending_delete
vmconfig_undelete_pending_option -> remove_from_pending_delete
vmconfig_cleanup_pending -> cleanup_pending
parse_pending_delete now has a better representation of the force value,
which is encoded in a perl hash i.e. $conf->{$opt}->{force} = 1 or 0
depending on if the string in config has '!' or not.
Signed-off-by: Oguz Bektas <o.bektas@proxmox.com>
This is the bash completion helper function for completing the snapshot
name. This is used both in qemu-server and pve-container.
This patch is the base for the patches in qemu-server and pve-container.
Signed-off-by: Rhonda D'Vine <rhonda@proxmox.com>
instead move the QEMU machine logic inside qemu-server package with
the help of the new snapshot rollback hook
Signed-off-by: Dominik Csapak <d.csapak@proxmox.com>
