From a6f5b35851987254b1954aea5f9d28d10f7b8274 Mon Sep 17 00:00:00 2001 From: Fiona Ebner Date: Wed, 13 Dec 2023 15:17:45 +0100 Subject: [PATCH] replication: prepare: include volumes without snapshots in the result Note that PVE::Storage::volume_snapshot_info() will fail when a volume does not exist, so no non-existing volume will end up in the result (prepare() is only called with volumes that should exist). This makes it possible to detect a volume without snapshots in the result of prepare(), and as a consequence, replication will now also fail early in a situation where source and remote volume both exist, but (at least) one of them doesn't have any snapshots. Such a situation can happen, for example, by deleting and re-creating a volume with the same name on the source side without running replication after deletion. Signed-off-by: Fiona Ebner --- src/PVE/Replication.pm | 2 ++ 1 file changed, 2 insertions(+) diff --git a/src/PVE/Replication.pm b/src/PVE/Replication.pm index bd627e5..05c2632 100644 --- a/src/PVE/Replication.pm +++ b/src/PVE/Replication.pm @@ -172,6 +172,8 @@ sub prepare { my $local_snapshots = {}; my $cleaned_replicated_volumes = {}; foreach my $volid (@$volids) { + $local_snapshots->{$volid} = {}; + my $info = PVE::Storage::volume_snapshot_info($storecfg, $volid); my $removal_ok = !defined($snapname) || $info->{$snapname};