proxmox-mirrors/pve-guest-common
1
0
Fork 0
mirror of https://git.proxmox.com/git/pve-guest-common synced 2025-08-16 06:34:41 +00:00
Code Issues Actions Packages Projects Releases Wiki Activity

tag helpers: add get_unique_tags method for filtering out duplicates

Browse Source 
tags must be unique, allow the user some control in how unique (case
sensitive) and honor the ordering settings (even if I doubt any
production setups wants to spent time and $$$ on cautiously
reordering all tags of their dozens to hundreds virtual guests..

Have some duplicate code to avoid checking to much in the loop
itself, as frequent branches can be more expensive.

Signed-off-by: Thomas Lamprecht <t.lamprecht@proxmox.com>
This commit is contained in:
Thomas Lamprecht 2022-11-21 08:09:24 +01:00
parent 2bf45e382a
commit 091598000c
1 changed files with 31 additions and 0 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

31
src/PVE/GuestHelpers.pm
View File

@ -335,4 +335,35 @@ sub assert_tag_permissions {
}
}
sub get_unique_tags {
my ($tags, $no_join_result) = @_;
$tags = [ split_list($tags // '') ] if ref($tags) ne 'ARRAY';
return !$no_join_result ? '': [] if !scalar($tags->@*);
my $datacenter_config = PVE::Cluster::cfs_read_file('datacenter.cfg');
my $tag_style_config = $datacenter_config->{'tag-style'} // {};
my $case_sensitive = !!$tag_style_config->{'case-sensitive'};
my $seen_tags = {};
my $res = [];
if (!defined($tag_style_config->{ordering}) || $tag_style_config->{ordering} ne 'config') {
for my $tag ( sort { $case_sensitive ? $a cmp $b : lc($a) cmp lc($b) } $tags->@*) {
$tag = lc($tag) if !$case_sensitive;
next if $seen_tags->{$tag};
$seen_tags->{$tag} = 1;
push @$res, $tag;
}
} else {
for my $tag ($tags->@*) {
$tag = lc($tag) if !$case_sensitive;
next if $seen_tags->{$tag};
$seen_tags->{$tag} = 1;
push @$res, $tag;
}
}
return !$no_join_result ? join(';', $res->@*) : $res;
}
1;