From f75a8ffbf7e24086f590ccfd67c3f6bb554d63f0 Mon Sep 17 00:00:00 2001
From: Thomas Lamprecht <t.lamprecht@proxmox.com>
Date: Wed, 10 Feb 2021 09:56:30 +0100
Subject: [PATCH] assemble: perlcritic: avoid unamed literal and two argument
 open

Signed-off-by: Thomas Lamprecht <t.lamprecht@proxmox.com>
---
 assemble-firmware.pl | 6 +++---
 1 file changed, 3 insertions(+), 3 deletions(-)

diff --git a/assemble-firmware.pl b/assemble-firmware.pl
index abbfbe9..a25a38c 100755
--- a/assemble-firmware.pl
+++ b/assemble-firmware.pl
@@ -304,8 +304,8 @@ my $fwdone = {};
 
 my $error = 0;
 
-open(TMP, $fwlist);
-while(defined(my $line = <TMP>)) {
+open(my $fd, '<', $fwlist);
+while(defined(my $line = <$fd>)) {
     chomp $line;
     my ($fw, $mod) = split(/\s+/, $line, 2);
 
@@ -398,6 +398,6 @@ while(defined(my $line = <TMP>)) {
     $error++;
     next;
 }
-close(TMP);
+close($fd);
 
 exit($error);