proxmox-mirrors/pve-common
1
0
Fork 0
mirror of https://git.proxmox.com/git/pve-common synced 2025-07-27 06:34:02 +00:00
Code Issues Actions Packages Projects Releases Wiki Activity

RESTenv: fork worker: fallback to 'root@pam' for task log user-id

Browse Source 
The fallback had a "typo" in the realm and used 'root@pve' (pve vs.
pam) since initial import from SVN, but off-list talks with Dietmar
suggest that 'root@pam' was always the intended fallback value.

Call sites without a defined user parameter (found only push_file and
pull_file from pve-container) were logging the task-owner user as
'root@pve' which isn't a default one, so it wouldn't exist in most
setups.

For clarity, add a comment that this is only used for the task logs.

Signed-off-by: Oguz Bektas <o.bektas@proxmox.com>
[ T: Reword/add to commit message slightly ]
Signed-off-by: Thomas Lamprecht <t.lamprecht@proxmox.com>
This commit is contained in:
Oguz Bektas 2022-03-15 12:52:39 +01:00 committed by Thomas Lamprecht
parent 06885ac8bb
commit f44838ff41
1 changed files with 2 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

3
src/PVE/RESTEnvironment.pm
View File

@ -492,7 +492,8 @@ sub fork_worker {
$dtype = 'unknown' if !defined ($dtype); $dtype = 'unknown' if !defined ($dtype);
$id = '' if !defined ($id); $id = '' if !defined ($id);
$user = 'root@pve' if !defined ($user); # note: below is only used for the task log entry
$user = $self->get_user(1) // 'root@pam' if !defined($user);
my $sync = ($self->{type} eq 'cli' && !$background) ? 1 : 0; my $sync = ($self->{type} eq 'cli' && !$background) ? 1 : 0;