From e8ab2427d696e4d3d0d840f8928b99a89a812bed Mon Sep 17 00:00:00 2001 From: Dominik Csapak Date: Mon, 11 Nov 2024 12:05:18 +0100 Subject: [PATCH] sysfstools: file_write: extend with logging the actual error and path is useful to know when trying to debug or figure out what did not work, so warn here if there was an error. Signed-off-by: Dominik Csapak --- src/PVE/SysFSTools.pm | 13 ++++++++++--- 1 file changed, 10 insertions(+), 3 deletions(-) diff --git a/src/PVE/SysFSTools.pm b/src/PVE/SysFSTools.pm index 0bde6d7..428e6ec 100644 --- a/src/PVE/SysFSTools.pm +++ b/src/PVE/SysFSTools.pm @@ -211,17 +211,24 @@ sub check_iommu_support{ return PVE::Tools::dir_glob_regex('/sys/class/iommu/', "[^\.].*"); } +# writes $buf into $filename, on success returns 1, on error returns 0 and warns sub file_write { my ($filename, $buf) = @_; my $fh = IO::File->new($filename, "w"); return undef if !$fh; - my $res = defined(syswrite($fh, $buf)) ? 1 : 0; - + my $res = syswrite($fh, $buf); + my $syserr = $!; # only relevant if $res is undefined $fh->close(); - return $res; + if (defined($res)) { + return 1; + } elsif ($syserr) { + warn "error writing '$buf' to '$filename': $syserr\n"; + } + + return 0; } sub pci_device_info {