proxmox-mirrors/pve-common
1
0
Fork 0
mirror of https://git.proxmox.com/git/pve-common synced 2025-06-03 02:42:36 +00:00
Code Issues Actions Packages Projects Releases Wiki Activity

fix mac address generation limitation

Browse Source 
Commit de9a267 introduced vec() to optimize the generation
by using binary operations instead of converting back and
forth between hex and strings, but forgot to switch over to
the binary sha1 method. This resulted in only the first 6
hex digits of the output string making up the address.
This commit is contained in:
Wolfgang Bumiller 2016-07-05 12:40:23 +02:00 committed by Fabian Grünbichler
parent e561bc74bb
commit d743b69c4b
1 changed files with 1 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

2
src/PVE/Tools.pm
View File

@ -983,7 +983,7 @@ sub random_ether_addr {
my ($seconds, $microseconds) = gettimeofday;
my $rand = Digest::SHA::sha1_hex($$, rand(), $seconds, $microseconds);
my $rand = Digest::SHA::sha1($$, rand(), $seconds, $microseconds);
# clear multicast, set local id
vec($rand, 0, 8) = (vec($rand, 0, 8) & 0xfe) | 2;