proxmox-mirrors/pve-common
1
0
Fork 0
mirror of https://git.proxmox.com/git/pve-common synced 2025-06-06 01:27:09 +00:00
Code Issues Actions Packages Projects Releases Wiki Activity

prevent autovivification of sectionconfig options

Browse Source 
If, somehow, someone passes a config to check_config with keys set
that are not in the options for that type, this fixed check
lead to autovivification, meaning that any future calls to the same
worker had an additional option for that type which is not optional

this lead to a wrongfully deleting of entries when updating an entry of
a different type, since all entries of the original types suddenly
did not satisfy their required options and would not get parsed
by read_file anymore (thus missing when a successful write_file was done)

Signed-off-by: Dominik Csapak <d.csapak@proxmox.com>
This commit is contained in:
Dominik Csapak 2019-05-15 10:03:50 +02:00 committed by Thomas Lamprecht
parent c0b8717c44
commit d0ba18e17e
1 changed files with 3 additions and 3 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

6
src/PVE/SectionConfig.pm
View File

@ -379,10 +379,10 @@ sub check_config {
foreach my $k (keys %$config) {
my $value = $config->{$k};
die "can't change value of fixed parameter '$k'\n"
if !$create && $opts->{$k}->{fixed};
if !$create && $opts->{$k} && $opts->{$k}->{fixed};
if (defined($value)) {
my $tmp = $class->check_value($type, $k, $value, $sectionId, $skipSchemaCheck);
$settings->{$k} = $class->decode_value($type, $k, $tmp);