use warnings everywhere.

This commit is contained in:
Dietmar Maurer 2013-10-01 13:19:38 +02:00
parent b98a06a32c
commit c36f332e32
9 changed files with 10 additions and 5 deletions

View File

@ -1,6 +1,7 @@
package PVE::AtomicFile; package PVE::AtomicFile;
use strict; use strict;
use warnings;
use IO::AtomicFile; use IO::AtomicFile;
use vars qw(@ISA); use vars qw(@ISA);

View File

@ -1,12 +1,11 @@
#!/usr/bin/perl -w package PVE::Exception;
# a way to add more information to exceptions (see man perlfunc (die)) # a way to add more information to exceptions (see man perlfunc (die))
# use PVE::Exception qw(raise); # use PVE::Exception qw(raise);
# raise ("my error message", code => 400, errors => { param1 => "err1", ...} ); # raise ("my error message", code => 400, errors => { param1 => "err1", ...} );
package PVE::Exception;
use strict; use strict;
use warnings;
use vars qw(@ISA @EXPORT_OK); use vars qw(@ISA @EXPORT_OK);
require Exporter; require Exporter;
use Storable qw(dclone); use Storable qw(dclone);

View File

@ -3,6 +3,8 @@ package PVE::INotify;
# todo: maybe we do not need update_file() ? # todo: maybe we do not need update_file() ?
use strict; use strict;
use warnings;
use POSIX; use POSIX;
use IO::File; use IO::File;
use IO::Dir; use IO::Dir;

View File

@ -1,7 +1,7 @@
package PVE::JSONSchema; package PVE::JSONSchema;
use warnings;
use strict; use strict;
use warnings;
use Storable; # for dclone use Storable; # for dclone
use Getopt::Long; use Getopt::Long;
use Devel::Cycle -quiet; # todo: remove? use Devel::Cycle -quiet; # todo: remove?

View File

@ -1,6 +1,7 @@
package PVE::Network; package PVE::Network;
use strict; use strict;
use warnings;
use PVE::Tools qw(run_command); use PVE::Tools qw(run_command);
use PVE::ProcFSTools; use PVE::ProcFSTools;
use PVE::INotify; use PVE::INotify;

View File

@ -1,6 +1,7 @@
package PVE::PodParser; package PVE::PodParser;
use strict; use strict;
use warnings;
use Pod::Parser; use Pod::Parser;
use base qw(Pod::Parser); use base qw(Pod::Parser);

View File

@ -1,6 +1,7 @@
package PVE::ProcFSTools; package PVE::ProcFSTools;
use strict; use strict;
use warnings;
use POSIX; use POSIX;
use Time::HiRes qw (gettimeofday); use Time::HiRes qw (gettimeofday);
use IO::File; use IO::File;

View File

@ -2,7 +2,6 @@ package PVE::RESTHandler;
use strict; use strict;
no strict 'refs'; # our autoload requires this no strict 'refs'; # our autoload requires this
use warnings; use warnings;
use PVE::SafeSyslog; use PVE::SafeSyslog;
use PVE::Exception qw(raise raise_param_exc); use PVE::Exception qw(raise raise_param_exc);

View File

@ -1,6 +1,7 @@
package PVE::Tools; package PVE::Tools;
use strict; use strict;
use warnings;
use POSIX qw(EINTR); use POSIX qw(EINTR);
use IO::Socket::INET; use IO::Socket::INET;
use IO::Select; use IO::Select;