proxmox-mirrors/pve-common
1
0
Fork 0
mirror of https://git.proxmox.com/git/pve-common synced 2025-06-06 18:04:41 +00:00
Code Issues Actions Packages Projects Releases Wiki Activity

pbs: code cleanup param array assembly

Browse Source 
Signed-off-by: Thomas Lamprecht <t.lamprecht@proxmox.com>
This commit is contained in:
Thomas Lamprecht 2020-11-17 09:38:28 +01:00
parent 0cc6c7e01b
commit ad6b323758
1 changed files with 13 additions and 20 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

33
src/PVE/PBSClient.pm
View File

@ -205,9 +205,7 @@ sub get_snapshots {
my ($self, $opts) = @_; my ($self, $opts) = @_;
my $param = []; my $param = [];
if (defined($opts->{group})) { push @$param, $opts->{group} if defined($opts->{group});
push @$param, $opts->{group};
}
return $self->run_client_cmd("snapshots", $param); return $self->run_client_cmd("snapshots", $param);
}; };
@ -225,11 +223,11 @@ sub backup_tree {
die "archive name not provided\n" if !defined($pxarname); die "archive name not provided\n" if !defined($pxarname);
my $time = delete $opts->{time}; my $time = delete $opts->{time};
my $param = []; my $param = [
"$pxarname.pxar:$root",
push @$param, "$pxarname.pxar:$root"; '--backup-type', $type,
push @$param, '--backup-type', $type; '--backup-id', $id,
push @$param, '--backup-id', $id; ];
push @$param, '--backup-time', $time if defined($time); push @$param, '--backup-time', $time if defined($time);
return $self->run_raw_client_cmd('backup', $param, %$opts); return $self->run_raw_client_cmd('backup', $param, %$opts);
@ -244,14 +242,13 @@ sub restore_pxar {
die "archive name not provided\n" if !defined($pxarname); die "archive name not provided\n" if !defined($pxarname);
my $target = delete $opts->{target}; my $target = delete $opts->{target};
die "restore-target not provided\n" if !defined($target); die "restore-target not provided\n" if !defined($target);
#my $time = delete $opts->{time};
my $param = []; my $param = [
"$snapshot",
push @$param, "$snapshot"; "$pxarname.pxar",
push @$param, "$pxarname.pxar"; "$target",
push @$param, "$target"; "--allow-existing-dirs", 0,
push @$param, "--allow-existing-dirs", 0; ];
return $self->run_raw_client_cmd('restore', $param, %$opts); return $self->run_raw_client_cmd('restore', $param, %$opts);
}; };
@ -261,11 +258,7 @@ sub forget_snapshot {
die "snapshot not provided\n" if !defined($snapshot); die "snapshot not provided\n" if !defined($snapshot);
my $param = []; return $self->run_raw_client_cmd('forget', ["$snapshot"]);
push @$param, "$snapshot";
return $self->run_raw_client_cmd('forget', $param);
}; };
sub prune_group { sub prune_group {