proxmox-mirrors/pve-common
1
0
Fork 0
mirror of https://git.proxmox.com/git/pve-common synced 2025-07-24 20:52:30 +00:00
Code Issues Actions Packages Projects Releases Wiki Activity

trim event and check if empty

Browse Source 
give a meaningful error if it is empty and disallow it instead of having
an implicit default (the default should be set by the component using
the calendarevent, not the calendarevent itself)

also add regression tests

Signed-off-by: Dominik Csapak <d.csapak@proxmox.com>
This commit is contained in:
Dominik Csapak 2017-06-13 11:25:33 +02:00 committed by Dietmar Maurer
parent 3dabe28a23
commit a5ffa49fda
2 changed files with 19 additions and 0 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

7
src/PVE/CalendarEvent.pm
View File

@ -5,6 +5,7 @@ use warnings;
use Data::Dumper;
use Time::Local;
use PVE::JSONSchema;
use PVE::Tools qw(trim);
# Note: This class implements a parser/utils for systemd like calender exents
# Date specification is currently not implemented
@ -36,6 +37,12 @@ sub pve_verify_calendar_event {
sub parse_calendar_event {
my ($event) = @_;
$event = trim($event);
if ($event eq '') {
die "unable to parse calendar event - event is empty\n";
}
my $parse_single_timespec = sub {
my ($p, $max, $matchall_ref, $res_hash) = @_;

12
test/calendar_event_test.pl
View File

@ -145,6 +145,18 @@ my $tests = [
'0..80',
{ error => "range end '80' out of range" },
],
[
' mon 0 0 0',
{ error => "unable to parse calendar event - unused parts" },
],
[
'',
{ error => "unable to parse calendar event - event is empty" },
],
[
' mon 0 0',
{ error => "unable to parse calendar event - unused parts" },
],
];
foreach my $test (@$tests) {