proxmox-mirrors/pve-common
1
0
Fork 0
mirror of https://git.proxmox.com/git/pve-common synced 2025-07-27 10:01:38 +00:00
Code Issues Actions Packages Projects Releases Wiki Activity

INotify.pm: use run_command instead of open for calling diff

Browse Source 
Signed-off-by: Dominik Csapak <d.csapak@proxmox.com>
This commit is contained in:
Dominik Csapak 2018-09-13 14:55:52 +02:00 committed by Dietmar Maurer
parent 1b505ae239
commit 69758574a1
1 changed files with 7 additions and 8 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

15
src/PVE/INotify.pm
View File

@ -19,7 +19,8 @@ use PVE::ProcFSTools;
use Clone qw(clone); use Clone qw(clone);
use Linux::Inotify2; use Linux::Inotify2;
use base 'Exporter'; use base 'Exporter';
use JSON; use JSON;
use Encode qw(encode decode);
our @EXPORT_OK = qw(read_file write_file register_file); our @EXPORT_OK = qw(read_file write_file register_file);
@ -56,13 +57,11 @@ sub ccache_compute_diff {
my $diff = ''; my $diff = '';
open (TMP, "diff -b -N -u '$filename' '$shadow'|"); my $cmd = ['/usr/bin/diff', '-b', '-N', '-u', $filename, $shadow];
PVE::Tools::run_command($cmd, noerr => 1, outfunc => sub {
while (my $line = <TMP>) { my ($line) = @_;
$diff .= $line; $diff .= decode('UTF-8', $line) . "\n";
} });
close (TMP);
$diff = undef if !$diff; $diff = undef if !$diff;