From 683d81c2a2ba70cbfde34f47ed1ebaff57e207ff Mon Sep 17 00:00:00 2001 From: Wolfgang Bumiller Date: Tue, 8 Mar 2016 14:14:13 +0100 Subject: [PATCH] net: tap_plug() needs to apply rate limiting Any action we take in tap_plug() when using OVS will undo our rate limiting, which means any hotplug change must restore the previous rate setting. Since this means tap_plug() would always be followed by a tap_rate_limit() call anyway we just include the rate parameter here and let the caller decide whether the full tap_plug() is required or the simple tap_rate_limit() suffices. --- data/PVE/Network.pm | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/data/PVE/Network.pm b/data/PVE/Network.pm index 00639f6..df6ad76 100644 --- a/data/PVE/Network.pm +++ b/data/PVE/Network.pm @@ -217,7 +217,7 @@ my $cleanup_firewall_bridge = sub { }; sub tap_plug { - my ($iface, $bridge, $tag, $firewall) = @_; + my ($iface, $bridge, $tag, $firewall, $rate) = @_; #cleanup old port config from any openvswitch bridge eval {run_command("/usr/bin/ovs-vsctl del-port $iface", outfunc => sub {}, errfunc => sub {}) }; @@ -240,6 +240,8 @@ sub tap_plug { &$ovs_bridge_add_port($bridge, $iface, $tag); } } + + tap_rate_limit($iface, $rate); } sub tap_unplug {