proxmox-mirrors/pve-common
1
0
Fork 0
mirror of https://git.proxmox.com/git/pve-common synced 2025-08-05 11:01:07 +00:00
Code Issues Actions Packages Projects Releases Wiki Activity

network: add support for disabling bridge learning on tap|veth|fwln ports

Browse Source 
Currently, if bridge receive an unknown dest mac (network bug/attack/..),
we are flooding packets to all bridge ports.

This can waste cpu time, even more with firewall enabled.
Also, if firewall is used with reject action, the src mac of RST
packet is the original unknown dest mac.
(This can block the server at Hetzner for example)

So, we can disable learning && unicast_flood on tap|veth|fwln port interface.
Then mac address need to be add statically in bridge fdb.

Signed-off-by: Alexandre Derumier <aderumier@odiso.com>
This commit is contained in:
Alexandre Derumier 2021-09-24 10:48:54 +02:00 committed by Thomas Lamprecht
parent f44838ff41
commit 354ec8dee3
1 changed files with 54 additions and 6 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

60
src/PVE/Network.pm
View File

@ -208,6 +208,14 @@ sub disable_ipv6 {
close($fh);
}
my $bridge_disable_interface_learning = sub {
my ($iface) = @_;
PVE::ProcFSTools::write_proc_entry("/sys/class/net/$iface/brport/unicast_flood", "0");
PVE::ProcFSTools::write_proc_entry("/sys/class/net/$iface/brport/learning", "0");
};
my $bridge_add_interface = sub {
my ($bridge, $iface, $tag, $trunks) = @_;
@ -269,6 +277,43 @@ my $activate_interface = sub {
die "can't activate interface '$iface' - $@\n" if $@;
};
sub add_bridge_fdb {
my ($iface, $mac) = @_;
my $learning = PVE::Tools::file_read_firstline("/sys/class/net/$iface/brport/learning");
return if $learning;
my ($vmid, $devid) = &$parse_tap_device_name($iface, 1);
return if !defined($vmid);
PVE::Tools::run_command(['/sbin/bridge', 'fdb', 'append', $mac, 'dev', $iface, 'master', 'static']);
my ($fwbr, $vethfw, $vethfwpeer, $ovsintport) = &$compute_fwbr_names($vmid, $devid);
if (-d "/sys/class/net/$vethfwpeer") {
PVE::Tools::run_command(['/sbin/bridge', 'fdb', 'append', $mac, 'dev', $vethfwpeer, 'master', 'static']);
}
}
sub del_bridge_fdb {
my ($iface, $mac) = @_;
my $learning = PVE::Tools::file_read_firstline("/sys/class/net/$iface/brport/learning");
return if $learning;
my ($vmid, $devid) = &$parse_tap_device_name($iface, 1);
return if !defined($vmid);
PVE::Tools::run_command(['/sbin/bridge', 'fdb', 'del', $mac, 'dev', $iface, 'master', 'static']);
my ($fwbr, $vethfw, $vethfwpeer, $ovsintport) = &$compute_fwbr_names($vmid, $devid);
if (-d "/sys/class/net/$vethfwpeer") {
PVE::Tools::run_command(['/sbin/bridge', 'fdb', 'del', $mac, 'dev', $vethfwpeer, 'master', 'static']);
}
}
sub tap_create {
my ($iface, $bridge) = @_;
@ -323,7 +368,7 @@ sub veth_delete {
}
my $create_firewall_bridge_linux = sub {
my ($iface, $bridge, $tag, $trunks) = @_;
my ($iface, $bridge, $tag, $trunks, $disablelearning) = @_;
my ($vmid, $devid) = &$parse_tap_device_name($iface);
my ($fwbr, $vethfw, $vethfwpeer) = &$compute_fwbr_names($vmid, $devid);
@ -334,14 +379,15 @@ my $create_firewall_bridge_linux = sub {
copy_bridge_config($bridge, $fwbr);
veth_create($vethfw, $vethfwpeer, $bridge);
&$bridge_add_interface($fwbr, $vethfw);
&$bridge_add_interface($bridge, $vethfwpeer, $tag, $trunks);
&$bridge_disable_interface_learning($vethfwpeer) if $disablelearning;
&$bridge_add_interface($fwbr, $vethfw);
&$bridge_add_interface($fwbr, $iface);
};
my $create_firewall_bridge_ovs = sub {
my ($iface, $bridge, $tag, $trunks) = @_;
my ($iface, $bridge, $tag, $trunks, $disablelearning) = @_;
my ($vmid, $devid) = &$parse_tap_device_name($iface);
my ($fwbr, undef, undef, $ovsintport) = &$compute_fwbr_names($vmid, $devid);
@ -360,6 +406,7 @@ my $create_firewall_bridge_ovs = sub {
PVE::Tools::run_command(['/sbin/ip', 'link', 'set', $ovsintport, 'mtu', $bridgemtu]);
&$bridge_add_interface($fwbr, $ovsintport);
&$bridge_disable_interface_learning($ovsintport) if $disablelearning;
};
my $cleanup_firewall_bridge = sub {
@ -384,7 +431,7 @@ my $cleanup_firewall_bridge = sub {
};
sub tap_plug {
my ($iface, $bridge, $tag, $firewall, $trunks, $rate) = @_;
my ($iface, $bridge, $tag, $firewall, $trunks, $rate, $disablelearning) = @_;
#cleanup old port config from any openvswitch bridge
eval {run_command("/usr/bin/ovs-vsctl del-port $iface", outfunc => sub {}, errfunc => sub {}) };
@ -403,16 +450,17 @@ sub tap_plug {
}
if ($firewall) {
&$create_firewall_bridge_linux($iface, $bridge, $tag, $trunks);
&$create_firewall_bridge_linux($iface, $bridge, $tag, $trunks, $disablelearning);
} else {
&$bridge_add_interface($bridge, $iface, $tag, $trunks);
}
&$bridge_disable_interface_learning($iface) if $disablelearning;
} else {
&$cleanup_firewall_bridge($iface); # remove stale devices
if ($firewall) {
&$create_firewall_bridge_ovs($iface, $bridge, $tag, $trunks);
&$create_firewall_bridge_ovs($iface, $bridge, $tag, $trunks, $disablelearning);
} else {
&$ovs_bridge_add_port($bridge, $iface, $tag, undef, $trunks);
}