proxmox-mirrors/pve-common
1
0
Fork 0
mirror of https://git.proxmox.com/git/pve-common synced 2025-07-29 16:25:50 +00:00
Code Issues Actions Packages Projects Releases Wiki Activity

INotify.pm: use Clone::clone instead of Storable::dclone

Browse Source 
I run into seroius troubles with dclone, which seem to be
buggy with tainted flag ...

Also, documentation states Clone::clone is much faster.
This commit is contained in:
Dietmar Maurer 2017-03-21 11:56:49 +01:00
parent e04b9f4c43
commit 32ef45aee2
1 changed files with 4 additions and 4 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

8
src/PVE/INotify.pm
View File

@ -15,7 +15,7 @@ use PVE::SafeSyslog;
use PVE::Exception qw(raise_param_exc); use PVE::Exception qw(raise_param_exc);
use PVE::Tools; use PVE::Tools;
use PVE::ProcFSTools; use PVE::ProcFSTools;
use Storable qw(dclone); use Clone qw(clone);
use Linux::Inotify2; use Linux::Inotify2;
use base 'Exporter'; use base 'Exporter';
use JSON; use JSON;
@ -247,7 +247,7 @@ sub read_file {
my $ret; my $ret;
if (!$noclone && ref ($ccinfo->{data})) { if (!$noclone && ref ($ccinfo->{data})) {
$ret->{data} = dclone ($ccinfo->{data}); $ret->{data} = clone ($ccinfo->{data});
} else { } else {
$ret->{data} = $ccinfo->{data}; $ret->{data} = $ccinfo->{data};
} }
@ -269,7 +269,7 @@ sub read_file {
} }
# we cache data with references, so we always need to # we cache data with references, so we always need to
# dclone this data. Else the original data may get # clone this data. Else the original data may get
# modified. # modified.
$ccinfo->{data} = $res; $ccinfo->{data} = $res;
@ -278,7 +278,7 @@ sub read_file {
my $ret; my $ret;
if (!$noclone && ref ($ccinfo->{data})) { if (!$noclone && ref ($ccinfo->{data})) {
$ret->{data} = dclone ($ccinfo->{data}); $ret->{data} = clone ($ccinfo->{data});
} else { } else {
$ret->{data} = $ccinfo->{data}; $ret->{data} = $ccinfo->{data};
} }