proxmox-mirrors/pve-common
1
0
Fork 0
mirror of https://git.proxmox.com/git/pve-common synced 2025-05-29 06:09:26 +00:00
Code Issues Actions Packages Projects Releases Wiki Activity

Use run_command instead of system

Browse Source 
and explicitly note that those calls are allowed to fail and
are wrapped in eval {} on purpose.
This commit is contained in:
Fabian Grünbichler 2016-05-02 15:03:03 +02:00 committed by Dietmar Maurer
parent a7f30ebf27
commit 2d6b3a90db
1 changed files with 5 additions and 4 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

9
src/PVE/Network.pm
View File

@ -76,10 +76,11 @@ our $ipv4_mask_hash_localnet = {
sub setup_tc_rate_limit {
my ($iface, $rate, $burst, $debug) = @_;
system("/sbin/tc class del dev $iface parent 1: classid 1:1 >/dev/null 2>&1");
system("/sbin/tc filter del dev $iface parent ffff: protocol all pref 50 u32 >/dev/null 2>&1");
system("/sbin/tc qdisc del dev $iface ingress >/dev/null 2>&1");
system("/sbin/tc qdisc del dev $iface root >/dev/null 2>&1");
# these are allowed / expected to fail, e.g. when there is no previous rate limit to remove
eval { run_command("/sbin/tc class del dev $iface parent 1: classid 1:1 >/dev/null 2>&1"); };
eval { run_command("/sbin/tc filter del dev $iface parent ffff: protocol all pref 50 u32 >/dev/null 2>&1"); };
eval { run_command("/sbin/tc qdisc del dev $iface ingress >/dev/null 2>&1"); };
eval { run_command("/sbin/tc qdisc del dev $iface root >/dev/null 2>&1"); };
return if !$rate;