proxmox-mirrors/pve-common
1
0
Fork 0
mirror of https://git.proxmox.com/git/pve-common synced 2025-04-28 22:35:12 +00:00
Code Issues Actions Packages Projects Releases Wiki Activity

read firstline: only map ENOENT to undef, raise error otherwise

Browse Source 
Errors like permission denied or I/O ones should bubble up, otherwise
it might hide serious issues and seemingly continue to work, with a
wrong state or the like.

One could argue that the case for not existent should return undef,
while an empty file should return an empty string, but for that we
might want to check all use-sites first.

Signed-off-by: Thomas Lamprecht <t.lamprecht@proxmox.com>
This commit is contained in:
Thomas Lamprecht 2023-06-13 07:12:06 +02:00
parent aa4898ebbe
commit 1ac0a30a0a
1 changed files with 4 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

5
src/PVE/Tools.pm
View File

@ -291,7 +291,10 @@ sub file_read_firstline {
my ($filename) = @_;
my $fh = IO::File->new ($filename, "r");
return undef if !$fh;
if (!$fh) {
return undef if $! == POSIX::ENOENT;
die "file '$filename' exists but open for reading failed - $!\n";
}
my $res = <$fh>;
chomp $res if $res;
$fh->close;