proxmox-mirrors/pve-common
1
0
Fork 0
mirror of https://git.proxmox.com/git/pve-common synced 2025-07-27 10:01:38 +00:00
Code Issues Actions Packages Projects Releases Wiki Activity

Daemon: keep lock file open during restart

Browse Source 
So that nobody else can grab the lock
This commit is contained in:
Dietmar Maurer 2014-12-31 11:54:27 +01:00
parent a8ba2293d4
commit 1a6bc2f371
1 changed files with 41 additions and 16 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

49
data/PVE/Daemon.pm
View File

@ -67,11 +67,17 @@ my $lockpidfile = sub {
my $lkfn = $self->{pidfile} . ".lock"; my $lkfn = $self->{pidfile} . ".lock";
if (my $fd = $self->{env_pve_lock_fd}) {
$self->{daemon_lock_fh} = IO::Handle->new_from_fd($fd, "a");
} else {
$self->{daemon_lock_fh} = IO::File->new(">>$lkfn"); $self->{daemon_lock_fh} = IO::File->new(">>$lkfn");
}
if (!$self->{daemon_lock_fh}) { if (!$self->{daemon_lock_fh}) {
my $msg = "can't aquire lock on file '$lkfn' - $!"; die "can't open lock '$lkfn' - $!\n";
syslog ('err', $msg);
die "ERROR: $msg\n";
} }
for (my $i = 0; $i < 5; $i ++) { for (my $i = 0; $i < 5; $i ++) {
@ -81,9 +87,7 @@ my $lockpidfile = sub {
if (!flock ($self->{daemon_lock_fh}, LOCK_EX|LOCK_NB)) { if (!flock ($self->{daemon_lock_fh}, LOCK_EX|LOCK_NB)) {
&$close_daemon_lock($self); &$close_daemon_lock($self);
my $msg = "can't aquire lock '$lkfn' - $!"; die "can't aquire lock '$lkfn' - $!\n";
syslog ('err', $msg);
die "ERROR: $msg\n";
} }
}; };
@ -217,8 +221,18 @@ my $terminate_server = sub {
my $server_run = sub { my $server_run = sub {
my ($self, $debug) = @_; my ($self, $debug) = @_;
# fixme: handle restart lockfd
&$lockpidfile($self); &$lockpidfile($self);
# remove FD_CLOEXEC bit to reuse on exec
$self->{daemon_lock_fh}->fcntl(Fcntl::F_SETFD(), 0);
$ENV{PVE_DAEMON_LOCK_FD} = $self->{daemon_lock_fh}->fileno;
# my $fd = POSIX::dup($self->{daemon_lock_fh}) ||
# die "unable to duplicate daemon_lock_fh\n";
# run in background # run in background
my $spid; my $spid;
@ -340,27 +354,30 @@ my $server_run = sub {
sub new { sub new {
my ($this, $name, $cmdline, %params) = @_; my ($this, $name, $cmdline, %params) = @_;
my $restart = $ENV{RESTART_PVE_DAEMON}; die "missing name" if !$name;
initlog($name);
my $restart = $ENV{RESTART_PVE_DAEMON};
delete $ENV{RESTART_PVE_DAEMON}; delete $ENV{RESTART_PVE_DAEMON};
die "please run as root\n" if !$restart && ($> != 0); my $lockfd = $ENV{PVE_DAEMON_LOCK_FD};
delete $ENV{PVE_DAEMON_LOCK_FD};
die "missing name" if !$name; die "please run as root\n" if !$restart && ($> != 0);
die "can't create more that one PVE::Daemon" if $daemon_initialized; die "can't create more that one PVE::Daemon" if $daemon_initialized;
$daemon_initialized = 1; $daemon_initialized = 1;
PVE::INotify::inotify_init(); PVE::INotify::inotify_init();
initlog($name);
my $class = ref($this) || $this; my $class = ref($this) || $this;
my $self = bless { my $self = bless {
name => $name, name => $name,
run_dir => '/var/run', run_dir => '/var/run',
env_restart_pve_daemon => $restart, env_restart_pve_daemon => $restart,
env_pve_lock_fd => $lockfd,
workers => {}, workers => {},
}, $class; }, $class;
@ -460,7 +477,10 @@ sub run {
sub start { sub start {
my ($self, $debug) = @_; my ($self, $debug) = @_;
&$server_run($self, $debug); eval { &$server_run($self, $debug); };
if (my $err = $@) {
syslog('err', "start failed - $err");
}
} }
my $read_pid = sub { my $read_pid = sub {
@ -516,9 +536,14 @@ sub stop {
} }
if (-f $self->{pidfile}) { if (-f $self->{pidfile}) {
eval {
# try to get the lock # try to get the lock
&$lockpidfile($self); &$lockpidfile($self);
&$server_cleanup($self); &$server_cleanup($self);
};
if (my $err = $@) {
syslog('err', "cleanup failed - $err");
}
} }
} }