proxmox-mirrors/pve-access-control
1
0
Fork 0
mirror of https://git.proxmox.com/git/pve-access-control synced 2025-10-04 22:22:25 +00:00
Code Issues Actions Packages Projects Releases Wiki Activity

authenticate_user: pass undef instead of empty $tfa_challenge to authenticate_2nd_new

Browse Source 
just above, we check & return if $tfa_challenge is set, so there is no
way that it would be set here. To make it clearer that it must be undef
here pass it as such.

Signed-off-by: Dominik Csapak <d.csapak@proxmox.com>
This commit is contained in:
Dominik Csapak 2022-10-21 10:31:17 +02:00 committed by Wolfgang Bumiller
parent 61565fb2c5
commit 965b2418ee
1 changed files with 1 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

2
src/PVE/AccessControl.pm
View File

@ -746,7 +746,7 @@ sub authenticate_user : prototype($$$$;$) {
if ($new_format) { if ($new_format) {
# This is the first factor with an optional immediate 2nd factor for TOTP: # This is the first factor with an optional immediate 2nd factor for TOTP:
my $tfa_challenge = authenticate_2nd_new($username, $realm, $otp, $tfa_challenge); my $tfa_challenge = authenticate_2nd_new($username, $realm, $otp, undef);
return wantarray ? ($username, $tfa_challenge) : $username; return wantarray ? ($username, $tfa_challenge) : $username;
} else { } else {
return authenticate_2nd_old($username, $realm, $otp); return authenticate_2nd_old($username, $realm, $otp);