proxmox-mirrors/pve-access-control
1
0
Fork 0
mirror of https://git.proxmox.com/git/pve-access-control synced 2025-10-04 15:53:07 +00:00
Code Issues Actions Packages Projects Releases Wiki Activity

auth ldap/ad: compare group member dn case-insensitively

Browse Source 
currently we add a user to a group if it's DN is listed in the
member-attributes of a group. The comparison for this is done via
existence check of a hash key, which is case-sensitive.

The equality for DNs is defined in a not straight forward way [0]:
(roughly translating to you need to honor the equality rules for each
'component' (RDN) of the DN) and is implementation-specific (Microsoft
AD is case-insensitive).

While this patch does not address the complete complexity of comparing
DNs it should work fine in practice.

issue with case-sensitive mismatches was reported in our community
forum:
https://forum.proxmox.com/threads/.113387

tested against a local test-vm used for reproducing the issue.

[0] https://ldapwiki.com/wiki/Distinguished%20Name%20Case%20Sensitivity

Signed-off-by: Stoiko Ivanov <s.ivanov@proxmox.com>
This commit is contained in:
Stoiko Ivanov 2022-08-29 18:07:55 +02:00 committed by Thomas Lamprecht
parent 28ec897247
commit 931e5bc19f
1 changed files with 2 additions and 2 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

4
src/PVE/Auth/LDAP.pm
View File

@ -310,7 +310,7 @@ sub get_users {
if (wantarray) {
my $dn = $user->{dn};
$dnmap->{$dn} = $username;
$dnmap->{lc($dn)} = $username;
}
}
@ -351,7 +351,7 @@ sub get_groups {
$ret->{$name} = { users => {} };
foreach my $member (@{$group->{members}}) {
if (my $user = $dnmap->{$member}) {
if (my $user = $dnmap->{lc($member)}) {
$ret->{$name}->{users}->{$user} = 1;
}
}