proxmox-mirrors/pve-access-control
1
0
Fork 0
mirror of https://git.proxmox.com/git/pve-access-control synced 2025-10-04 20:39:24 +00:00
Code Issues Actions Packages Projects Releases Wiki Activity

access: lookup: avoid reading user.cfg from cfs unnecessarily

Browse Source 
Given that the information is only needed for case-sensitive realms,
move the read into the conditional.

No functional changes.

Signed-off-by: Christoph Heiss <c.heiss@proxmox.com>
This commit is contained in:
Christoph Heiss 2025-03-25 11:38:32 +01:00 committed by Thomas Lamprecht
parent 1471e1e822
commit 6e0d55a587
1 changed files with 1 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

2
src/PVE/AccessControl.pm
View File

@ -1223,9 +1223,9 @@ sub lookup_username {
my $realm = $2; my $realm = $2;
my $domain_cfg = cfs_read_file("domains.cfg"); my $domain_cfg = cfs_read_file("domains.cfg");
my $casesensitive = $domain_cfg->{ids}->{$realm}->{'case-sensitive'} // 1; my $casesensitive = $domain_cfg->{ids}->{$realm}->{'case-sensitive'} // 1;
my $usercfg = cfs_read_file('user.cfg');
if (!$casesensitive) { if (!$casesensitive) {
my $usercfg = cfs_read_file('user.cfg');
my @matches = grep { lc $username eq lc $_ } (keys %{$usercfg->{users}}); my @matches = grep { lc $username eq lc $_ } (keys %{$usercfg->{users}});
die "ambiguous case insensitive match of username '$username', cannot safely grant access!\n" die "ambiguous case insensitive match of username '$username', cannot safely grant access!\n"