proxmox-mirrors/pve-access-control
1
0
Fork 0
mirror of https://git.proxmox.com/git/pve-access-control synced 2025-06-13 15:27:32 +00:00
Code Issues Actions Packages Projects Releases Wiki Activity

cleanup: avoid writing user.cfg twice

Browse Source
This commit is contained in:
Dietmar Maurer 2015-08-14 07:55:36 +02:00
parent 66931b1141
commit 57a704731b
1 changed files with 6 additions and 4 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

10
PVE/AccessControl.pm
View File

@ -1093,18 +1093,20 @@ sub remove_vm_access {
my ($vmid) = @_; my ($vmid) = @_;
my $delVMaccessFn = sub { my $delVMaccessFn = sub {
my $usercfg = cfs_read_file("user.cfg"); my $usercfg = cfs_read_file("user.cfg");
my $modified;
if (my $acl = $usercfg->{acl}->{'/vms/'.$vmid}) { if (my $acl = $usercfg->{acl}->{"/vms/$vmid"}) {
delete $usercfg->{acl}->{'/vms/'.$vmid}; delete $usercfg->{acl}->{"/vms/$vmid"};
cfs_write_file("user.cfg", $usercfg); $modified = 1;
} }
if (my $pool = $usercfg->{vms}->{$vmid}) { if (my $pool = $usercfg->{vms}->{$vmid}) {
if (my $data = $usercfg->{pools}->{$pool}) { if (my $data = $usercfg->{pools}->{$pool}) {
delete $data->{vms}->{$vmid}; delete $data->{vms}->{$vmid};
delete $usercfg->{vms}->{$vmid}; delete $usercfg->{vms}->{$vmid};
cfs_write_file("user.cfg", $usercfg); $modified = 1;
} }
} }
cfs_write_file("user.cfg", $usercfg) if $modified;
}; };
lock_user_config($delVMaccessFn, "access permissions cleanup for VM $vmid failed"); lock_user_config($delVMaccessFn, "access permissions cleanup for VM $vmid failed");