From 070694541469dbc98986a178b823c4475c54fb75 Mon Sep 17 00:00:00 2001 From: Fiona Ebner Date: Thu, 17 Jul 2025 15:36:50 +0200 Subject: [PATCH] privileges: drop VM.Monitor The name VM.Monitor is ambiguous and makes it hard to guess what the privilege is for. The privilege was used for two things: 1. QEMU guest agent operations, for which dedicated privileges were introduced, see commit "add VM.GuestAgent privileges". 2. Access to the QEMU HMP monitor, where only the 'info' and 'help' commands were usable without an additional Sys.Modify privilege. Access to the monitor will be guarded with Sys.Audit. Signed-off-by: Fiona Ebner Link: https://lore.proxmox.com/20250717133711.84715-3-f.ebner@proxmox.com --- src/PVE/AccessControl.pm | 1 - src/test/perm-test1.pl | 8 ++++---- 2 files changed, 4 insertions(+), 5 deletions(-) diff --git a/src/PVE/AccessControl.pm b/src/PVE/AccessControl.pm index 3e12850..e48e647 100644 --- a/src/PVE/AccessControl.pm +++ b/src/PVE/AccessControl.pm @@ -1061,7 +1061,6 @@ my $privgroups = { 'VM.Clone', 'VM.GuestAgent.Unrestricted', 'VM.Migrate', - 'VM.Monitor', 'VM.Snapshot', 'VM.Snapshot.Rollback', ], diff --git a/src/test/perm-test1.pl b/src/test/perm-test1.pl index bf01ac6..50b46e2 100755 --- a/src/test/perm-test1.pl +++ b/src/test/perm-test1.pl @@ -66,8 +66,8 @@ check_permission( . 'VM.Allocate,VM.Audit,VM.Backup,VM.Clone,VM.Config.CDROM,VM.Config.CPU,VM.Config.Cloudinit,' . 'VM.Config.Disk,VM.Config.HWType,VM.Config.Memory,VM.Config.Network,VM.Config.Options,' . 'VM.Console,VM.GuestAgent.Audit,VM.GuestAgent.FileRead,VM.GuestAgent.FileSystemMgmt,' - . 'VM.GuestAgent.FileWrite,VM.GuestAgent.Unrestricted,VM.Migrate,VM.Monitor,VM.PowerMgmt,' - . 'VM.Snapshot,VM.Snapshot.Rollback', + . 'VM.GuestAgent.FileWrite,VM.GuestAgent.Unrestricted,VM.Migrate,VM.PowerMgmt,VM.Snapshot,' + . 'VM.Snapshot.Rollback', ); # Administrator -> Permissions.Modify! check_permission( @@ -86,8 +86,8 @@ check_permission( . 'VM.Allocate,VM.Audit,VM.Backup,VM.Clone,VM.Config.CDROM,VM.Config.CPU,VM.Config.Cloudinit,' . 'VM.Config.Disk,VM.Config.HWType,VM.Config.Memory,VM.Config.Network,VM.Config.Options,' . 'VM.Console,VM.GuestAgent.Audit,VM.GuestAgent.FileRead,VM.GuestAgent.FileSystemMgmt,' - . 'VM.GuestAgent.FileWrite,VM.GuestAgent.Unrestricted,VM.Migrate,VM.Monitor,VM.PowerMgmt,' - . 'VM.Snapshot,VM.Snapshot.Rollback', + . 'VM.GuestAgent.FileWrite,VM.GuestAgent.Unrestricted,VM.Migrate,VM.PowerMgmt,VM.Snapshot,' + . 'VM.Snapshot.Rollback', ); check_roles('max@pve', '/vms/200', 'storage_manager');