mirror of
https://git.proxmox.com/git/proxmox
synced 2025-08-06 05:51:04 +00:00
![]() We currently calculate the size of a datastore using `statfs64`, which returns the number of blocks in the fs and the two block sizes: fragemented block size(f_frsize) and block size (f_bsize). To calculate eg the total space in a datastore we use total_blocks * f_bsize, which is not always correct. `f_frsize` is the minimum unit of allocation on the filesystem (in bytes) and in 99% of the cases equal to `f_bsize`, but in some cases it differs. For example some filesystems allow smaller blocks for small files, in case f_frsize < f_bsize. In that case, f_frsize * total_blocks returns (mostly) the correct result (ceph also did some weird stuff, which is now being fixed though [0][1]). `statvfs` also documents this as the recommended way ('fsblkcnt_t f_blocks; /* Size of fs in f_frsize units */')[2]. This patch aligns the the behavior with the libc utilities (also used by `df`) [3]. Motivation: [4] (Forum post) [0]: https://tracker.ceph.com/issues/3793 [1]: https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/commit/?id=92a49fb0f79f3300e6e50ddf56238e70678e4202 [2]: https://www.man7.org/linux/man-pages/man3/statvfs.3.html [3]: https://git.savannah.gnu.org/cgit/gnulib.git/tree/lib/fsusage.c#n147 [4]: https://forum.proxmox.com/threads/pbs-3-1-2-wrong-datastore-information-sshfs.139875/#post-626959 Signed-off-by: Gabriel Goller <g.goller@proxmox.com> |
||
---|---|---|
.cargo | ||
proxmox-acme | ||
proxmox-api-macro | ||
proxmox-apt | ||
proxmox-async | ||
proxmox-auth-api | ||
proxmox-borrow | ||
proxmox-client | ||
proxmox-compression | ||
proxmox-http | ||
proxmox-http-error | ||
proxmox-human-byte | ||
proxmox-io | ||
proxmox-lang | ||
proxmox-ldap | ||
proxmox-login | ||
proxmox-metrics | ||
proxmox-notify | ||
proxmox-openid | ||
proxmox-rest-server | ||
proxmox-router | ||
proxmox-rrd | ||
proxmox-schema | ||
proxmox-section-config | ||
proxmox-serde | ||
proxmox-shared-memory | ||
proxmox-sortable-macro | ||
proxmox-subscription | ||
proxmox-sys | ||
proxmox-tfa | ||
proxmox-time | ||
proxmox-uuid | ||
.gitignore | ||
build.sh | ||
bump.sh | ||
Cargo.toml | ||
Makefile | ||
README.rst | ||
rustfmt.toml |
Local cargo config ================== This repository ships with a ``.cargo/config`` that replaces the crates.io registry with packaged crates located in ``/usr/share/cargo/registry``. A similar config is also applied building with dh_cargo. Cargo.lock needs to be deleted when switching between packaged crates and crates.io, since the checksums are not compatible. To reference new dependencies (or updated versions) that are not yet packaged, the dependency needs to point directly to a path or git source. Steps for Releases ================== - Run ./bump.sh <CRATE> [patch|minor|major|<VERSION>] -- Fill out changelog -- Confirm bump commit - Build packages with `make deb`. -- Don't forget to commit updated d/control! Adding Crates ============= 1) At the top level: - Generate the crate: ``cargo new --lib the-name`` - Sort the crate into ``Cargo.toml``'s ``workspace.members`` 2) In the new crate's ``Cargo.toml``: - In ``[package]`` set: authors.workspace = true license.workspace = true edition.workspace = true exclude.workspace = true repository.workspace = true - Add a meaningful ``description`` - Copy ``debian/copyright`` and ``debian/debcargo.toml`` from another subcrate. Adding a new Dependency ======================= 1) At the top level: - Add it to ``[workspace.dependencies]`` specifying the version and any features that should be enabled throughout the workspace 2) In each member's ``Cargo.toml``: - Add it to the desired dependencies section with ``workspace = true`` and no version specified. - If this member requires additional features, add only the extra features to the member dependency. Updating a Dependency's Version =============================== 1) At the top level: - Bump the version in ``[workspace.dependencies]`` as desired. - Check for deprecations or breakage throughout the workspace. Notes on Workspace Inheritance ============================== Common metadata (like authors, license, ..) are inherited throughout the workspace. If new fields are added that are identical for all crates, they should be defined in the top-level ``Cargo.toml`` file's ``[workspace.package]`` section, and inherited in all members explicitly by setting ``FIELD.workspace = true`` in the member's ``[package]`` section. Dependency information is also inherited throughout the workspace, allowing a single dependency specification in the top-level Cargo.toml file to be used by all members. Some restrictions apply: - features can only be added in members, never removed (this includes ``default_features = false``!) - the base feature set at the workspace level should be the minimum (possibly empty!) set required by all members - workspace dependency specifications cannot include ``optional`` - if needed, the ``optional`` flag needs to be set at the member level when using a workspace dependency