proxmox-mirrors/proxmox
1
0
Fork 1
mirror of https://git.proxmox.com/git/proxmox synced 2025-06-15 18:27:35 +00:00
Code Issues Actions Packages Projects Releases Wiki Activity

maintenance: add 'Unmount' maintenance type

Browse Source 
Signed-off-by: Dietmar Maurer <dietmar@proxmox.com>
Signed-off-by: Hannes Laimer <h.laimer@proxmox.com>
This commit is contained in:
Dietmar Maurer 2024-11-25 17:21:50 +01:00 committed by Thomas Lamprecht
parent 6134a73b1e
commit fd1f8413f7
2 changed files with 10 additions and 2 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

3
pbs-api-types/src/datastore.rs
View File

@ -401,6 +401,9 @@ impl DataStoreConfig {
match current_type { match current_type {
Some(MaintenanceType::ReadOnly) => { /* always OK */ } Some(MaintenanceType::ReadOnly) => { /* always OK */ }
Some(MaintenanceType::Offline) => { /* always OK */ } Some(MaintenanceType::Offline) => { /* always OK */ }
Some(MaintenanceType::Unmount) => {
bail!("datastore is being unmounted");
}
Some(MaintenanceType::Delete) => { Some(MaintenanceType::Delete) => {
match new_type { match new_type {
Some(MaintenanceType::Delete) => { /* allow to delete a deleted storage */ } Some(MaintenanceType::Delete) => { /* allow to delete a deleted storage */ }

9
pbs-api-types/src/maintenance.rs
View File

@ -38,7 +38,6 @@ pub enum Operation {
/// Maintenance type. /// Maintenance type.
pub enum MaintenanceType { pub enum MaintenanceType {
// TODO: // TODO:
// - Add "unmounting" once we got pluggable datastores
// - Add "GarbageCollection" or "DeleteOnly" as type and track GC (or all deletes) as separate // - Add "GarbageCollection" or "DeleteOnly" as type and track GC (or all deletes) as separate
// operation, so that one can enable a mode where nothing new can be added but stuff can be // operation, so that one can enable a mode where nothing new can be added but stuff can be
// cleaned // cleaned
@ -48,6 +47,8 @@ pub enum MaintenanceType {
Offline, Offline,
/// The datastore is being deleted. /// The datastore is being deleted.
Delete, Delete,
/// The (removable) datastore is being unmounted.
Unmount,
} }
serde_plain::derive_display_from_serialize!(MaintenanceType); serde_plain::derive_display_from_serialize!(MaintenanceType);
serde_plain::derive_fromstr_from_deserialize!(MaintenanceType); serde_plain::derive_fromstr_from_deserialize!(MaintenanceType);
@ -79,7 +80,9 @@ pub struct MaintenanceMode {
impl MaintenanceMode { impl MaintenanceMode {
/// Used for deciding whether the datastore is cleared from the internal cache /// Used for deciding whether the datastore is cleared from the internal cache
pub fn clear_from_cache(&self) -> bool { pub fn clear_from_cache(&self) -> bool {
self.ty == MaintenanceType::Offline || self.ty == MaintenanceType::Delete self.ty == MaintenanceType::Offline
|| self.ty == MaintenanceType::Delete
|| self.ty == MaintenanceType::Unmount
} }
pub fn check(&self, operation: Option<Operation>) -> Result<(), Error> { pub fn check(&self, operation: Option<Operation>) -> Result<(), Error> {
@ -93,6 +96,8 @@ impl MaintenanceMode {
if let Some(Operation::Lookup) = operation { if let Some(Operation::Lookup) = operation {
return Ok(()); return Ok(());
} else if self.ty == MaintenanceType::Unmount {
bail!("datastore is being unmounted");
} else if self.ty == MaintenanceType::Offline { } else if self.ty == MaintenanceType::Offline {
bail!("offline maintenance mode: {}", message); bail!("offline maintenance mode: {}", message);
} else if self.ty == MaintenanceType::ReadOnly { } else if self.ty == MaintenanceType::ReadOnly {