proxmox-mirrors/proxmox
1
0
Fork 1
mirror of https://git.proxmox.com/git/proxmox synced 2025-07-26 22:44:30 +00:00
Code Issues Actions Packages Projects Releases Wiki Activity

login: make password optional when creating Login requests

Browse Source 
in certain context (for example, the browser), no password needs to be
provided when using HttpOnly cookies as they are handle by said
context. so make renewing ticket with password optional and add a new
helper function that does not require a password.

Signed-off-by: Shannon Sterz <s.sterz@proxmox.com>
This commit is contained in:
Shannon Sterz 2025-03-04 15:42:37 +01:00 committed by Wolfgang Bumiller
parent 9c6d6b8d2a
commit f137b5e528
1 changed files with 15 additions and 4 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

19
proxmox-login/src/lib.rs
View File

@ -50,7 +50,7 @@ pub struct Request {
pub struct Login {
api_url: String,
userid: String,
password: String,
password: Option<String>,
pve_compat: bool,
}
@ -96,7 +96,18 @@ impl Login {
api_url: normalize_url(api_url.into()),
pve_compat: ticket.product() == "PVE",
userid: ticket.userid().to_string(),
password: ticket.into(),
password: Some(ticket.into()),
}
}
/// Prepare a request with the assumption that the context handles the ticket (usually in a
/// browser via an HttpOnly cookie).
pub fn renew_with_cookie(api_url: impl Into<String>, userid: impl Into<String>) -> Self {
Self {
api_url: normalize_url(api_url.into()),
pve_compat: false,
userid: userid.into(),
password: None,
}
}
@ -109,7 +120,7 @@ impl Login {
Self {
api_url: normalize_url(api_url.into()),
userid: userid.into(),
password: password.into(),
password: Some(password.into()),
pve_compat: false,
}
}
@ -129,7 +140,7 @@ impl Login {
let request = api::CreateTicket {
new_format: self.pve_compat.then_some(true),
username: self.userid.clone(),
password: Some(self.password.clone()),
password: self.password.clone(),
..Default::default()
};