proxmox-mirrors/proxmox
1
0
Fork 1
mirror of https://git.proxmox.com/git/proxmox synced 2025-06-14 22:43:46 +00:00
Code Issues Actions Packages Projects Releases Wiki Activity

api-macro: clippy fixes

Browse Source 
Signed-off-by: Wolfgang Bumiller <w.bumiller@proxmox.com>
This commit is contained in:
Wolfgang Bumiller 2021-11-30 17:00:27 +01:00
parent 60fa521095
commit e461be1c9f
4 changed files with 10 additions and 9 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

4
proxmox-api-macro/src/api/method.rs
View File

@ -356,7 +356,7 @@ fn handle_function_signature(
// Found an explicit parameter: extract it: // Found an explicit parameter: extract it:
ParameterType::Normal(NormalParameter { ParameterType::Normal(NormalParameter {
ty: &pat_type.ty, ty: &pat_type.ty,
entry: &entry, entry,
}) })
} else if is_api_method_type(&pat_type.ty) { } else if is_api_method_type(&pat_type.ty) {
if api_method_param.is_some() { if api_method_param.is_some() {
@ -567,7 +567,7 @@ fn extract_normal_parameter(
) -> Result<(), Error> { ) -> Result<(), Error> {
let span = name_span; // renamed during refactorization let span = name_span; // renamed during refactorization
let name_str = syn::LitStr::new(name.as_str(), span); let name_str = syn::LitStr::new(name.as_str(), span);
let arg_name = Ident::new(&format!("input_arg_{}", name.as_ident().to_string()), span); let arg_name = Ident::new(&format!("input_arg_{}", name.as_ident()), span);
let default_value = param.entry.schema.find_schema_property("default"); let default_value = param.entry.schema.find_schema_property("default");

4
proxmox-api-macro/src/api/mod.rs
View File

@ -443,7 +443,7 @@ pub enum OptionType {
/// An updater type uses its "base" type's field's updaters to determine whether the field is /// An updater type uses its "base" type's field's updaters to determine whether the field is
/// supposed to be an option. /// supposed to be an option.
Updater(syn::Type), Updater(Box<syn::Type>),
} }
impl OptionType { impl OptionType {
@ -465,7 +465,7 @@ impl From<bool> for OptionType {
impl From<syn::Type> for OptionType { impl From<syn::Type> for OptionType {
fn from(ty: syn::Type) -> Self { fn from(ty: syn::Type) -> Self {
OptionType::Updater(ty) OptionType::Updater(Box::new(ty))
} }
} }

1
proxmox-api-macro/src/serde.rs
View File

@ -8,6 +8,7 @@ use std::convert::TryFrom;
use crate::util::{AttrArgs, FieldName}; use crate::util::{AttrArgs, FieldName};
/// Serde name types. /// Serde name types.
#[allow(clippy::enum_variant_names)]
#[derive(Clone, Copy, Debug, Eq, PartialEq)] #[derive(Clone, Copy, Debug, Eq, PartialEq)]
pub enum RenameAll { pub enum RenameAll {
LowerCase, LowerCase,

10
proxmox-api-macro/src/util.rs
View File

@ -561,7 +561,7 @@ pub fn make_path(span: Span, leading_colon: bool, path: &[&str]) -> syn::Path {
None None
}, },
segments: path segments: path
.into_iter() .iter()
.map(|entry| syn::PathSegment { .map(|entry| syn::PathSegment {
ident: Ident::new(entry, span), ident: Ident::new(entry, span),
arguments: syn::PathArguments::None, arguments: syn::PathArguments::None,
@ -682,9 +682,9 @@ impl<T> Maybe<T> {
} }
} }
impl<T> Into<Option<T>> for Maybe<T> { impl<T> From<Maybe<T>> for Option<T> {
fn into(self) -> Option<T> { fn from(maybe: Maybe<T>) -> Option<T> {
match self { match maybe {
Maybe::Explicit(t) | Maybe::Derived(t) => Some(t), Maybe::Explicit(t) | Maybe::Derived(t) => Some(t),
Maybe::None => None, Maybe::None => None,
} }
@ -694,7 +694,7 @@ impl<T> Into<Option<T>> for Maybe<T> {
/// Helper to iterate over all the `#[derive(...)]` types found in an attribute list. /// Helper to iterate over all the `#[derive(...)]` types found in an attribute list.
pub fn derived_items(attributes: &[syn::Attribute]) -> DerivedItems { pub fn derived_items(attributes: &[syn::Attribute]) -> DerivedItems {
DerivedItems { DerivedItems {
attributes: attributes.into_iter(), attributes: attributes.iter(),
current: None, current: None,
} }
} }