proxmox-mirrors/proxmox
1
0
Fork 1
mirror of https://git.proxmox.com/git/proxmox synced 2025-08-15 08:47:25 +00:00
Code Issues Actions Packages Projects Releases Wiki Activity

proxmox: cleanup files on fsync errors

Browse Source 
Signed-off-by: Wolfgang Bumiller <w.bumiller@proxmox.com>
This commit is contained in:
Wolfgang Bumiller 2021-10-21 12:42:20 +02:00
parent a0cfb9c20d
commit bdc7e9d145
1 changed files with 12 additions and 2 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

14
proxmox/src/tools/fs.rs
View File

@ -184,7 +184,10 @@ pub fn replace_file<P: AsRef<Path>>(
if fsync { if fsync {
// make sure data is on disk // make sure data is on disk
nix::unistd::fsync(file.as_raw_fd())?; if let Err(err) = nix::unistd::fsync(file.as_raw_fd()) {
let _ = unistd::unlink(&tmp_path);
bail!("fsync failed: {}", err);
}
} }
if let Err(err) = std::fs::rename(&tmp_path, &path) { if let Err(err) = std::fs::rename(&tmp_path, &path) {
@ -261,7 +264,14 @@ pub fn atomic_open_or_create_file<P: AsRef<Path>>(
})?; })?;
if fsync { if fsync {
// make sure the initial_data is on disk // make sure the initial_data is on disk
nix::unistd::fsync(file.as_raw_fd())?; if let Err(err) = nix::unistd::fsync(file.as_raw_fd()) {
let _ = nix::unistd::unlink(&temp_file_name);
bail!(
"fsync of initial data to {:?} failed - {}",
temp_file_name,
err,
)
}
} }
} }