proxmox-mirrors/proxmox
1
0
Fork 1
mirror of https://git.proxmox.com/git/proxmox synced 2025-08-13 17:16:41 +00:00
Code Issues Actions Packages Projects Releases Wiki Activity

fix #3302: allow for more characters for email

Browse Source 
by removing the regex check here, that is responsibility of the caller

this is ok since we pass the args directly and not via shell, so
command injection should not be possible

Signed-off-by: Dominik Csapak <d.csapak@proxmox.com>
This commit is contained in:
Dominik Csapak 2021-05-12 16:20:16 +02:00 committed by Thomas Lamprecht
parent fa3b5374ed
commit a7f4002306
1 changed files with 1 additions and 14 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

15
proxmox/src/tools/email.rs
View File

@ -16,23 +16,10 @@ pub fn sendmail(
mailfrom: Option<&str>,
author: Option<&str>,
) -> Result<(), Error> {
let mail_regex = regex::Regex::new(r"^[a-zA-Z\.0-9-]+@[a-zA-Z\.0-9-]+$").unwrap();
if mailto.is_empty() {
bail!("At least one recipient has to be specified!")
}
for recipient in mailto {
if !mail_regex.is_match(recipient) {
bail!("'{}' is not a valid email address", recipient)
}
}
let mailfrom = mailfrom.unwrap_or("root");
if !mailfrom.eq("root") && !mail_regex.is_match(mailfrom) {
bail!("'{}' is not a valid email address", mailfrom)
}
let recipients = mailto.join(",");
let author = author.unwrap_or("Proxmox Backup Server");
@ -44,7 +31,7 @@ pub fn sendmail(
.arg("-f")
.arg(mailfrom)
.arg("--")
.arg(&recipients)
.args(mailto)
.stdin(Stdio::piped())
.spawn()
{