proxmox-mirrors/proxmox
1
0
Fork 1
mirror of https://git.proxmox.com/git/proxmox synced 2025-07-04 06:59:03 +00:00
Code Issues Actions Packages Projects Releases Wiki Activity

ldap: avoid superfluous allocation when calling .search()

Browse Source 
The `attrs` parameter of `Ldap::search()` is an `impl AsRef<[impl
AsRef<str>]>` anyway, so replace `vec![..]` with `&[..]`.

Suggested-by: Wolfgang Bumiller <w.bumiller@proxmox.com>
Signed-off-by: Christoph Heiss <c.heiss@proxmox.com>
This commit is contained in:
Christoph Heiss 2024-01-12 17:15:56 +01:00 committed by Thomas Lamprecht
parent 78bf05a458
commit 84fbfb22ec
1 changed files with 2 additions and 7 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

9
proxmox-ldap/src/lib.rs
View File

@ -181,12 +181,7 @@ impl Connection {
// only search base to make sure the base_dn exists while avoiding most common size limits // only search base to make sure the base_dn exists while avoiding most common size limits
let (_, _) = ldap let (_, _) = ldap
.search( .search(&self.config.base_dn, Scope::Base, "(objectClass=*)", &["*"])
&self.config.base_dn,
Scope::Base,
"(objectClass=*)",
vec!["*"],
)
.await? .await?
.success() .success()
.context("Could not search LDAP realm, base_dn could be incorrect")?; .context("Could not search LDAP realm, base_dn could be incorrect")?;
@ -319,7 +314,7 @@ impl Connection {
let query = format!("(&({}={}))", self.config.user_attr, username); let query = format!("(&({}={}))", self.config.user_attr, username);
let (entries, _res) = ldap let (entries, _res) = ldap
.search(&self.config.base_dn, Scope::Subtree, &query, vec!["dn"]) .search(&self.config.base_dn, Scope::Subtree, &query, &["dn"])
.await? .await?
.success()?; .success()?;