From 8468dd18d2d26ba67d31b2875b6c90edddc2028d Mon Sep 17 00:00:00 2001 From: Christian Ebner Date: Sat, 5 Apr 2025 11:05:05 +0200 Subject: [PATCH] pbs-api-types: add option to set GC chunk cleanup atime cutoff Add the `gc-atime-cutoff` option to the datastore tuning parameters. This allows to specify the time after which the chunks are not considered in use anymore if their atime has not been updated since then. The default is to keep chunks within the 24h 5m timespan (given no active writers). Signed-off-by: Christian Ebner --- pbs-api-types/src/datastore.rs | 15 +++++++++++++++ 1 file changed, 15 insertions(+) diff --git a/pbs-api-types/src/datastore.rs b/pbs-api-types/src/datastore.rs index 1a4d9e2d..b174a047 100644 --- a/pbs-api-types/src/datastore.rs +++ b/pbs-api-types/src/datastore.rs @@ -223,6 +223,15 @@ pub enum DatastoreFSyncLevel { Filesystem, } +pub const GC_ATIME_CUTOFF_SCHEMA: Schema = IntegerSchema::new( + "Cutoff (in minutes) for chunk cleanup atime check in garbage collection phase 2 \ + (default 24h 5m)", +) +.minimum(1) // safety margin for kernel timestamp granularity, but stay within minute range +.maximum(2 * 24 * 60) +.default(24 * 60 + 5) +.schema(); + #[api( properties: { "chunk-order": { @@ -237,6 +246,10 @@ pub enum DatastoreFSyncLevel { default: true, type: bool, }, + "gc-atime-cutoff": { + schema: GC_ATIME_CUTOFF_SCHEMA, + optional: true, + }, }, )] #[derive(Serialize, Deserialize, Default)] @@ -250,6 +263,8 @@ pub struct DatastoreTuning { pub sync_level: Option, #[serde(skip_serializing_if = "Option::is_none")] pub gc_atime_safety_check: Option, + #[serde(skip_serializing_if = "Option::is_none")] + pub gc_atime_cutoff: Option, } pub const DATASTORE_TUNING_STRING_SCHEMA: Schema = StringSchema::new("Datastore tuning options")