From 70529722125ca42f39e76c1cd64cdf84d82526ba Mon Sep 17 00:00:00 2001 From: Maximiliano Sandoval Date: Wed, 7 Aug 2024 09:43:48 +0200 Subject: [PATCH] apt: clippy: don't clone types implementing Copy Fixes the clippy warnings: warning: `proxmox-apt` (lib) generated 1 warning warning: using `clone` on type `Option<[u8; 32]>` which implements the `Copy` trait --> proxmox-apt/tests/repositories.rs:117:22 | 117 | let old_digest = file.digest.clone().unwrap(); | ^^^^^^^^^^^^^^^^^^^ help: try removing the `clone` call: `file.digest` | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_on_copy = note: `#[warn(clippy::clone_on_copy)]` on by default warning: using `clone` on type `[u8; 32]` which implements the `Copy` trait --> proxmox-apt/tests/repositories.rs:135:24 | 135 | file.digest = Some(old_digest.clone()); | ^^^^^^^^^^^^^^^^^^ help: try removing the `clone` call: `old_digest` | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_on_copy Signed-off-by: Maximiliano Sandoval Reviewed-by: Lukas Wagner --- proxmox-apt/tests/repositories.rs | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/proxmox-apt/tests/repositories.rs b/proxmox-apt/tests/repositories.rs index 5211a360..b55bb420 100644 --- a/proxmox-apt/tests/repositories.rs +++ b/proxmox-apt/tests/repositories.rs @@ -114,7 +114,7 @@ fn test_digest() -> Result<(), Error> { let new_path = write_dir.join(path.file_name().unwrap()); file.path = Some(new_path.clone().into_os_string().into_string().unwrap()); - let old_digest = file.digest.clone().unwrap(); + let old_digest = file.digest.unwrap(); // file does not exist yet... assert!(file.read_with_digest().is_err()); @@ -132,7 +132,7 @@ fn test_digest() -> Result<(), Error> { repo.enabled = !repo.enabled; // ...then it should work - file.digest = Some(old_digest.clone()); + file.digest = Some(old_digest); file.write()?; // expect a different digest, because the repo was modified