From 52cf0c05f5fc08df834ff32224517c466081a6e9 Mon Sep 17 00:00:00 2001 From: Maximiliano Sandoval Date: Wed, 26 Jun 2024 14:43:46 +0200 Subject: [PATCH] auth-api: do not clone struct implementing Copy Fixes the clippy warning: warning: using `clone` on type `Option<&dyn AuthContext>` which implements the `Copy` trait --> proxmox-auth-api/src/api/mod.rs:111:5 | 111 | / AUTH_CONTEXT 112 | | .lock() 113 | | .unwrap() 114 | | .clone() | |________________^ | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_on_copy = note: `#[warn(clippy::clone_on_copy)]` on by default help: try dereferencing it | 111 ~ (*AUTH_CONTEXT 112 + .lock() 113 + .unwrap()) | Signed-off-by: Maximiliano Sandoval --- proxmox-auth-api/src/api/mod.rs | 6 +----- 1 file changed, 1 insertion(+), 5 deletions(-) diff --git a/proxmox-auth-api/src/api/mod.rs b/proxmox-auth-api/src/api/mod.rs index c4e507c3..82b4d42a 100644 --- a/proxmox-auth-api/src/api/mod.rs +++ b/proxmox-auth-api/src/api/mod.rs @@ -108,11 +108,7 @@ pub fn set_auth_context(auth_context: &'static dyn AuthContext) { } fn auth_context() -> Result<&'static dyn AuthContext, Error> { - AUTH_CONTEXT - .lock() - .unwrap() - .clone() - .ok_or_else(|| format_err!("no realm access configured")) + (*AUTH_CONTEXT.lock().unwrap()).ok_or_else(|| format_err!("no realm access configured")) } struct UserAuthData {