From 480e213f7c802c48d10e963c8b0fb5d4f134d11a Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Fabian=20Gr=C3=BCnbichler?= Date: Tue, 18 May 2021 09:23:37 +0200 Subject: [PATCH] websocket: add note about compat removal MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit this major release still needs to have an incompatible, the next one can drop setting a protocol client-side, and the one after that can remove the protocol handling on the server side. Signed-off-by: Fabian Grünbichler --- proxmox-http/src/websocket/mod.rs | 2 ++ 1 file changed, 2 insertions(+) diff --git a/proxmox-http/src/websocket/mod.rs b/proxmox-http/src/websocket/mod.rs index d15c8c52..4830db6a 100644 --- a/proxmox-http/src/websocket/mod.rs +++ b/proxmox-http/src/websocket/mod.rs @@ -692,6 +692,8 @@ impl WebSocket { .header(CONNECTION, HeaderValue::from_static("Upgrade")) .header(SEC_WEBSOCKET_ACCEPT, response_key); + // FIXME: remove compat in PBS 3.x + // // We currently do not support any subprotocols and we always send binary frames, // but for backwards compatibilty we need to reply the requested protocols if let Some(ws_proto) = headers.get(SEC_WEBSOCKET_PROTOCOL) {