tape: fix 'eject-before-unload' api type

by converting the bool into an option, otherwise having the options not
set at all will fail the unload while deserializing with
'eject-before-unload is not optional'

Also if we can automatically decide this in the future, we can now
detect if the option was explicitely set or not.

Fixes: 99f24b20 ("fix #4904: tape changer: add option to eject before unload")
Signed-off-by: Dominik Csapak <d.csapak@proxmox.com>
This commit is contained in:
Dominik Csapak 2023-12-13 11:11:12 +01:00 committed by Dietmar Maurer
parent 99f24b2079
commit 2cfa31a218

View File

@ -39,18 +39,21 @@ Import/Export, i.e. any media in those slots are considered to be
.format(&ApiStringFormat::PropertyString(&SLOT_ARRAY_SCHEMA))
.schema();
fn is_false(b: &bool) -> bool {
!b
}
#[api]
#[api(
properties: {
"eject-before-unload": {
optional: true,
default: false,
},
},
)]
#[derive(Serialize, Deserialize)]
#[serde(rename_all = "kebab-case")]
/// Options for Changers
pub struct ChangerOptions {
#[serde(default, skip_serializing_if = "is_false")]
#[serde(skip_serializing_if = "Option::is_none")]
/// if set to true, tapes are ejected manually before unloading
pub eject_before_unload: bool,
pub eject_before_unload: Option<bool>,
}
pub const CHANGER_OPTIONS_STRING_SCHEMA: Schema = StringSchema::new("Changer options")