From 1c81fc4cc1f0ec88a768dde875bbae097fb161d8 Mon Sep 17 00:00:00 2001 From: Thomas Lamprecht Date: Sun, 11 Jul 2021 13:05:16 +0200 Subject: [PATCH] rest: log response: avoid unnecessary mut on variable a match expresses the fallback slightly nicer and needs no mut, which is always nice to avoid. Signed-off-by: Thomas Lamprecht --- src/server/rest.rs | 9 ++++----- 1 file changed, 4 insertions(+), 5 deletions(-) diff --git a/src/server/rest.rs b/src/server/rest.rs index 64ede1c1..3a359ad0 100644 --- a/src/server/rest.rs +++ b/src/server/rest.rs @@ -152,14 +152,13 @@ fn log_response( let path = &path_query[..MAX_URI_QUERY_LENGTH.min(path_query.len())]; let status = resp.status(); - if !(status.is_success() || status.is_informational()) { let reason = status.canonical_reason().unwrap_or("unknown reason"); - let mut message = "request failed"; - if let Some(data) = resp.extensions().get::() { - message = &data.0; - } + let message = match resp.extensions().get::() { + Some(data) => &data.0, + None => "request failed", + }; log::error!( "{} {}: {} {}: [client {}] {}",