Commit Graph

6 Commits

Author SHA1 Message Date
Dominic Jäger
bcc48f062c input panel: Add drawing of layout
The drawing makes clear in a few seconds:
 - what columnT and columnB stand for
 - what additional containers and panels are created
 - to which of those the elements of column1, column2... go to

When you're in the JS debugger and lost overview of where in this
element hierarchy you are, you can quickly check xtype + layout. Then
consulting this drawing solves the mistery.

Signed-off-by: Dominic Jäger <d.jaeger@proxmox.com>
2021-01-26 18:54:49 +01:00
Thomas Lamprecht
455f5fe5ed input panel: support convenience top column
mirrors columnB (column bottom) but is placed on the top, i.e.,
columnT.

One can no conveniently set the following layout:

  +-------------------------------------+
  |                                     |
  |               columnT               |
  |                                     |
  +------------------+------------------+
  |                  |                  |
  |                  |                  |
  |   column1        |   column2        |
  |                  |                  |
  |                  |                  |
  +------------------+------------------+
  |                                     |
  |               columnB               |
  |                                     |
  +-------------------------------------+

(4 columns should work too, but we do not use that anywhere FWICT)

Signed-off-by: Thomas Lamprecht <t.lamprecht@proxmox.com>
2020-11-23 13:19:27 +01:00
Thomas Lamprecht
9beeadc77a input panel: make advanced column check more flexible
allow that any of the three column/docked definitions can be set,
without setting the first one to an empty array to go in that if
branch.

Note, column2 works fine, but I did not greatly test a sole
advancedColumnB definition, so there may be still some improvements
for fixes - but at that point the user could also use advancedItems
to have full control.

Signed-off-by: Thomas Lamprecht <t.lamprecht@proxmox.com>
2020-11-21 20:03:18 +01:00
Aaron Lauterer
71a084c2ff InputPanel: remove old code for useFieldContainer
`useFieldContainer` doesn't seem to be used anymore in any of our
products:
* PVE
* PMG
* PBS

it therefore can be considered dead code.

Signed-off-by: Aaron Lauterer <a.lauterer@proxmox.com>
2020-11-19 12:39:00 +01:00
Aaron Lauterer
71d5316545 InputPanel: fix column scaling behavior
When scaling the browsers content either via the browser itself or
because the OS has a different scaling / DPI setting, it can happen that
not all columns have enough space next to each other and thus the last
column is moved further below.

This happens especially on chromium bases browsers (e.g. chrome, edge).

Changing the layout to use extjs HBOXes with flex instead of columns
solves works well.

Signed-off-by: Aaron Lauterer <a.lauterer@proxmox.com>
2020-11-19 12:39:00 +01:00
Thomas Lamprecht
ecabd4379c cleanly separate sources from package build, move to own folder
compared result with `diffoscope`, saw now difference

Signed-off-by: Thomas Lamprecht <t.lamprecht@proxmox.com>
2020-06-06 17:43:03 +02:00