Commit Graph

30 Commits

Author SHA1 Message Date
Thomas Lamprecht
c59a0a3e43 combogrid: fix validation if valueField is different than displayField
Signed-off-by: Thomas Lamprecht <t.lamprecht@proxmox.com>
2019-08-16 12:44:33 +02:00
Dominik Csapak
94953ba8ea ComboGrid: add trigger to delete from ComboGrid
when we have a combogrid that may be empty, we now show a
little 'x' where the user can delete the content

this is not shown when the field is not allowed to be empty

we add a new css for this because triggers need a background image
with a very specific layout:

110x22px which is 5 icons in one image for the various states
(normal, hover, active, focused, focused hover)

the icon is taken from the theme-crisp
form/tag-field-item-close.png but rearranged to fit the size

Signed-off-by: Dominik Csapak <d.csapak@proxmox.com>
2019-08-13 15:37:26 +02:00
Thomas Lamprecht
1ccb53ecdb combogrid: add handling for historic set values currently not available
We can often run into situations where a value set in the past is not
valid anymore. An example could be a deleted network bridge, e.g., we
set the vNIC of a VM to 'vmbr1' but then we decide to obsolete that
and delete that one, one would now expect that the field gets marked
as invalid when editing the VM's vNIC, so add that behavior.

As sometimes this can be valid and wanted behavior (e.g., usb
passthrough, which is hot-pluggable), also add a switch do restore
the old behavior.

Note that the empty value is not handled by this change, we let the
existing "allowBlank" config switch handle that one.

Signed-off-by: Thomas Lamprecht <t.lamprecht@proxmox.com>
2019-07-18 15:55:38 +02:00
Thomas Lamprecht
f59a7b2350 combogrid: always set the initial value, even if not found
as else one lies to the user and only creates strange behavior,
one should see the values even if not there anymore, if this is a
invalid state is left for a later patch.

Signed-off-by: Thomas Lamprecht <t.lamprecht@proxmox.com>
2019-07-17 16:17:59 +02:00
Oguz Bektas
c8b66b2bfd KVComboBox: add setComboItems function
this allows to change the comboItems of a KVComboBox on the run

Signed-off-by: Oguz Bektas <o.bektas@proxmox.com>
2019-07-11 15:00:14 +02:00
Dominik Csapak
8311c0b1af node network: refactor bond mode array generation
Signed-off-by: Dominik Csapak <d.csapak@proxmox.com>
2019-07-10 12:26:54 +02:00
Thomas Lamprecht
1dd799589b network selector: allow to select IP too
not only CIDR.. maybe it could make sense to add a small child class
which  overwrites just the displayField and valueField to address

Signed-off-by: Thomas Lamprecht <t.lamprecht@proxmox.com>
2019-06-27 21:51:02 +02:00
Thomas Lamprecht
227159eca2 combogrid: add deleteEmpty and skipEmptyText
Slightly adapted from the proxmox textfield version of this

Signed-off-by: Thomas Lamprecht <t.lamprecht@proxmox.com>
2019-06-27 14:21:46 +02:00
Thomas Lamprecht
b69c301a94 textfield: validate after allowBlank 2019-06-27 14:21:17 +02:00
Thomas Lamprecht
a8131b5bce combo grid: add setAllowBlank to help bindings
Signed-off-by: Thomas Lamprecht <t.lamprecht@proxmox.com>
2019-06-26 16:05:56 +02:00
Thomas Lamprecht
e6bf8a81ac followup: network selector: refactor cidr6 merge logic
Signed-off-by: Thomas Lamprecht <t.lamprecht@proxmox.com>
2019-06-12 13:07:32 +02:00
Thomas Lamprecht
ce8c5365c2 followup: network selector: reorder columns and adapt widths
and use format_boolean to render the active column
also hide the type column by default, it often is not too important,
and can be derived from the interface name, e.g., vmbrX -> bridge,
bondX -> bond, etc.

Signed-off-by: Thomas Lamprecht <t.lamprecht@proxmox.com>
2019-06-12 13:03:25 +02:00
Tim Marx
607c37efd1 add network selector widget
Signed-off-by: Tim Marx <t.marx@proxmox.com>
2019-06-12 11:17:44 +02:00
Thomas Lamprecht
ec0798689f form: proxmox textfield: support binding 'allowBlank'
Signed-off-by: Thomas Lamprecht <t.lamprecht@proxmox.com>
2018-11-28 12:17:57 +01:00
Dominik Csapak
39d9914990 ComboGrid: open picker also when focusing an editable field
port commit
851c032d69ad5ae23725dd1add9e4084ebc12650
from pve-manager

commit message:

    ComboBoxes provided by UI frameworks normally show their selection
    possibilities once focused, ExtJS does this too but not on editable
    (and thus filterable) input fields. Add a logic which allows this too
    and streamlines the behavior of ComboGrid/Box like components.

    To avoid a glitch, where clicking the "picker trigger" (the down
    arrow which normally toggles the selection picker) would first focus
    the element - thus expanding it - and only then causing a toggle
    which collapses it again, we overwrite the 'Ext.form.trigger.Trigger'
    onMouseDown so that we can skip a expansion on this event.

    Signed-off-by: Thomas Lamprecht <t.lamprecht@proxmox.com>
2018-01-11 14:48:13 +01:00
Dominik Csapak
3ab80554c6 ComboGrid: improve setting 'editable' default value
port commit
bff876ecb5f3388b7d65c491680b9a40574e4744
from pve-manager

commit message:

    This allows child classes to use another default, the initialConfig
    didn't allowed that.
    This is also the ExtJS like way to set defaults.

    Signed-off-by: Thomas Lamprecht <t.lamprecht@proxmox.com>
2018-01-11 14:48:13 +01:00
Dominik Csapak
fa6dc53bcc add missing BondModeSelector to widget toolkit
this is needed for the node/NetworkEdit.js

Signed-off-by: Dominik Csapak <d.csapak@proxmox.com>
2017-11-14 11:35:48 +01:00
Dietmar Maurer
f6f0066aff LanguageSelector.js - add language selector 2017-10-04 11:16:22 +02:00
Dietmar Maurer
00ecc6db47 DateTimeField.js - relay change events 2017-09-21 09:36:36 +02:00
Dietmar Maurer
2e7bd1dcba form/DateTimeField.js - new widget to select Date with Time 2017-09-20 12:42:42 +02:00
Dietmar Maurer
a0ba293c12 add RRDTypeSelector class
Mostly copied from pve-manager.

- added gettext translations
- changed class and state name
2017-08-29 06:25:25 +02:00
Dietmar Maurer
f0372135cd try to use real config properties
to generate getter/setter functions (required for bind)
2017-03-29 18:47:19 +02:00
Dietmar Maurer
a4eeb5939d KVComboBox.js: use correct namespace 2017-03-27 13:02:18 +02:00
Dietmar Maurer
066babdc65 form/ComboGrid.js: imported from pve-manager 2017-03-27 11:04:46 +02:00
Dietmar Maurer
211267b8cc KVComboBox: imported from pve-manager 2017-02-25 10:20:12 +01:00
Dietmar Maurer
b2d1d61fec rename pveintegerfield to proxmoxintegerfield 2017-02-24 09:15:20 +01:00
Dietmar Maurer
2cebd14b9d rename integerfield to pveintegerfiled, implement deleteEmpty 2017-02-24 08:59:06 +01:00
Dietmar Maurer
d44fdf59f9 add integer field 2017-02-24 08:32:30 +01:00
Dietmar Maurer
fccec7c6c2 add Checkbox.js
Copied from pve-manager
2017-01-31 17:17:12 +01:00
Dietmar Maurer
a0ec162067 add TextField.js
Copied from pve-manager
2017-01-31 17:13:26 +01:00