when a combobox was editable, a click inside did not open the picker,
but it would if the combobox was not editable.
Since this is
1. Inconsistent
2. Inconvenient (the user has to specifically press the arrow)
we already had this implemented for our ComboGrid, but not for
regular comboboxes
This patch moves the code for this to an override for ComboBox, which
our ComboGrid then inherits (so we do not need it there anymore)
while at it, do some non-significant code-cleanup
* whitespace fixes
* don't shadow 'me' in the focus callback
* fix typo in comment
Originally this was implemented in pve-manager, commit
851c032d69ad5ae23725dd1add9e4084ebc12650
https://git.proxmox.com/?p=pve-manager.git;a=commitdiff;h=851c032d69ad5ae23725dd1add9e4084ebc12650
Signed-off-by: Dominik Csapak <d.csapak@proxmox.com>
Originally-by: Thomas Lamprecht <t.lamprecht@proxmox.com>
Signed-off-by: Thomas Lamprecht <t.lamprecht@proxmox.com>
vlan-raw-device && vlan-id field are only
enabled if interface name is different than interfaceX.Y
I have added a listener on iface,
to enable them live if user want a custom name for vlan interface
Signed-off-by: Alexandre Derumier <aderumier@odiso.com>
we use itemIds with '@' already in the ceph dashboard, and in
non-debug modeit works (as expected) but throws an error
while using ext-all-debug.js so override it to include the '@'
the regex was in place because in html4 the 'id' tag could only consist
letters ofthe mentioned regex, this was lifted in html5 though[0]
0: https://developer.mozilla.org/en-US/docs/Web/HTML/Global_attributes/id
Signed-off-by: Dominik Csapak <d.csapak@proxmox.com>
this fixes bug EXTJS_18900 where the tooltip of a piechart was always
shown for the first data entry with 0 percent of the pie chart
the relevant lines for the fix are
...
if (a === b) {
return false;
}
...
Signed-off-by: Dominik Csapak <d.csapak@proxmox.com>
Signed-off-by: Thomas Lamprecht <t.lamprecht@proxmox.com>
Currently the frontend validation only allows values 8-120 as prefix-lengths for
ipv6-cidr notations.
Following commit 70ea22506939f9687e1146c0f35247cfbe9225b8 in pve-common, this
patch changes that value to 128, which, while seldomly seen in regular setups
is technically correct.
Problem was reported by a user in the forum - they needed to set a length of
125, because their provider supplies only smaller networks. [0]
[0] https://forum.proxmox.com/threads/lxc-ipv6-why-8-120.52638/
Signed-off-by: Stoiko Ivanov <s.ivanov@proxmox.com>
the combination of firefox, touchscreen, mouse input and extjs
prevents normal click/touch input for buttons, lists, etc.
the workaround on firefox was to set
dom.w3c_touch_events.enabled
to 0 (in about:config)
or to upgrade to extjs >= 6.5.1 (of which there is no gpl release as of now)
so we introduce that workaround as it seems to not disrupt 'normal'
browsers and non-touchscreen devices
we then still have an issue with scrolling though, since extjs
now expects the user to drag the content instead of using the wheel
but it is still better than a completely non working interface
Signed-off-by: Dominik Csapak <d.csapak@proxmox.com>
this is a workaround for scrolling in toolbars, etc. in firefox with
the mouse.
while the result is not very "pretty", it maintains the old behaviour
for all other browsers and makes it work in firefox
we may drop this when we update to a new extjs release
commit 484bf3f29e58d0f96c65e6dca6b5dd95eaea180c from pve-manager
Signed-off-by: Thomas Lamprecht <t.lamprecht@proxmox.com>
adds a workaround, so that we restore the scroll position when we
restore the focus. Fixies an annoying issue where, if a user had an
ellemtn selected, scrolled down and then a store refresh re-rendered
the view it was scrolled back to the selected item and the user lost
his scrolling position.
Add also the 'jumpToFocus' flag to allow enabling the old behaviour
commit e6f2a94f4fff3c125e8406a21d8d6159aca1421e from pve-manager
Signed-off-by: Thomas Lamprecht <t.lamprecht@proxmox.com>
by default, extjs submits the language dependent decimal separator,
e.g., ',' (comma) for german and '.' (dot) for english.
We always want the dot.
commit 5c660b6d1302a5fbb3dcf477cf8b5adc9f798530 from pve-manager
Signed-off-by: Thomas Lamprecht <t.lamprecht@proxmox.com>
The parent method does this already in ExtJS 6
commit d19ffc1bb078e42a042c5c73797d713aa9cf9bcc from pve-manager
Signed-off-by: Thomas Lamprecht <t.lamprecht@proxmox.com>
