We can often run into situations where a value set in the past is not
valid anymore. An example could be a deleted network bridge, e.g., we
set the vNIC of a VM to 'vmbr1' but then we decide to obsolete that
and delete that one, one would now expect that the field gets marked
as invalid when editing the VM's vNIC, so add that behavior.
As sometimes this can be valid and wanted behavior (e.g., usb
passthrough, which is hot-pluggable), also add a switch do restore
the old behavior.
Note that the empty value is not handled by this change, we let the
existing "allowBlank" config switch handle that one.
Signed-off-by: Thomas Lamprecht <t.lamprecht@proxmox.com>
as else one lies to the user and only creates strange behavior,
one should see the values even if not there anymore, if this is a
invalid state is left for a later patch.
Signed-off-by: Thomas Lamprecht <t.lamprecht@proxmox.com>
we use itemIds with '@' already in the ceph dashboard, and in
non-debug modeit works (as expected) but throws an error
while using ext-all-debug.js so override it to include the '@'
the regex was in place because in html4 the 'id' tag could only consist
letters ofthe mentioned regex, this was lifted in html5 though[0]
0: https://developer.mozilla.org/en-US/docs/Web/HTML/Global_attributes/id
Signed-off-by: Dominik Csapak <d.csapak@proxmox.com>
CIDR column displays the same information in only on column,
no need to duplicate the information (by default)
Signed-off-by: Dominik Csapak <d.csapak@proxmox.com>
not only CIDR.. maybe it could make sense to add a small child class
which overwrites just the displayField and valueField to address
Signed-off-by: Thomas Lamprecht <t.lamprecht@proxmox.com>
and use format_boolean to render the active column
also hide the type column by default, it often is not too important,
and can be derived from the interface name, e.g., vmbrX -> bridge,
bondX -> bond, etc.
Signed-off-by: Thomas Lamprecht <t.lamprecht@proxmox.com>
The full package description is often quite long, and for upgrades
it's not relevant most of the time. But, it can be intresting to
have, if one wonders what a package is even used for.
So add a checkbox in the top bar which allows to switch between
showing and hiding the description, simply done by re-using the
'grid-row-body-hidden' ExtJS CSS class (got the idea from the
RowBody feature source code).
Default it to off, as it's better to not overwhelm users here with a
huge pile of text by default, showing the list of package with the
short one line title is enough most of the times, I'd guess.
Signed-off-by: Thomas Lamprecht <t.lamprecht@proxmox.com>
Tested-by: Tim Marx <t.marx@proxmox.com>
this fixes bug EXTJS_18900 where the tooltip of a piechart was always
shown for the first data entry with 0 percent of the pie chart
the relevant lines for the fix are
...
if (a === b) {
return false;
}
...
Signed-off-by: Dominik Csapak <d.csapak@proxmox.com>
Signed-off-by: Thomas Lamprecht <t.lamprecht@proxmox.com>
This is similar to how we did in panel/LogView but adds disabling
also to the label, not only the picker field, which is a bit nicer.
And no, it really does not seems like this can be done easier...
Signed-off-by: Thomas Lamprecht <t.lamprecht@proxmox.com>
similar to LogView, but expects the result from the /node/journal api call,
which is an array of strings, with start/endcursor instead of
an array of objects with line numbers
the new api call also does not accept start line numbers and limit,
so it is necessary to handle it differently
Signed-off-by: Dominik Csapak <d.csapak@proxmox.com>
move the "return early, because a request is already pending" into
the doLoad function, so that all calls to it underly the request
limiting, but note that such a new request is desired, and if so
schedule it once the current finishes. This ensures that scrolling
will always get honored, but does not produces multiple hanging
workers, at max one.
Signed-off-by: Thomas Lamprecht <t.lamprecht@proxmox.com>
do not poll the syslog api call multiple times simultaneously,
since it can be very costly, depending on the journal size
with this, there is always only one per client
Signed-off-by: Dominik Csapak <d.csapak@proxmox.com>
follow the logic we use in file selectors of the PVE gui, i.e., allow
editable but force a match and do not allow blank, this lets
quick filter this big list instead of scrolling, and searching if
something appears or not, even if one is may not be sure if/how this
was sorted...
Signed-off-by: Thomas Lamprecht <t.lamprecht@proxmox.com>
With u2f having a ticket doesn't mean we're logged in yet,
so we need to be able to distinguish between the two.
Signed-off-by: Wolfgang Bumiller <w.bumiller@proxmox.com>
use the view, viewmodel, controller style code, which makes the logic
much more understandable
this adds two features to it, namely a viewBuffer range, which controls
the distance to the end of the data on which the panel loads the next data
and an optional failCallback, which will be used for the cephlog
this also fixes#2151
Signed-off-by: Dominik Csapak <d.csapak@proxmox.com>
