From ae6a1cc90864bc45a7ad4754d36c0a0a82d2e992 Mon Sep 17 00:00:00 2001 From: Thomas Lamprecht Date: Tue, 13 Jul 2021 18:29:21 +0200 Subject: [PATCH] service view: avoid showing not installed services as error Signed-off-by: Thomas Lamprecht --- src/node/ServiceView.js | 15 +++++++++++---- 1 file changed, 11 insertions(+), 4 deletions(-) diff --git a/src/node/ServiceView.js b/src/node/ServiceView.js index 1114d95..a9e6020 100644 --- a/src/node/ServiceView.js +++ b/src/node/ServiceView.js @@ -146,7 +146,7 @@ Ext.define('Proxmox.node.ServiceView', { if (!unitState) { return ''; } - if (unitState === 'masked') { + if (unitState === 'masked' || unitState === 'not-found') { return "proxmox-disabled-row"; } else if (unitState === 'unknown') { if (record.get('name') === 'syslog') { @@ -178,9 +178,16 @@ Ext.define('Proxmox.node.ServiceView', { width: 100, sortable: true, dataIndex: 'state', - renderer: (v, meta, rec) => rec.get('unit-state') === 'masked' - ? gettext('disabled') - : v, + renderer: (value, meta, rec) => { + const unitState = rec.get('unit-state'); + if (unitState === 'masked') { + return gettext('disabled'); + } else if (unitState === 'not-found') { + return gettext('not installed'); + } else { + return value; + } + }, }, { header: gettext('Active'),