From 98d894d85adf54899a80d1d1dec3d5985c097b46 Mon Sep 17 00:00:00 2001 From: Dominik Csapak Date: Wed, 22 Apr 2020 09:26:23 +0200 Subject: [PATCH] improve multiselect behaviour for checkboxmodel when using the mode 'MULTI' for the checkbox selection model, clicking a row would deselect all others, only clicking exactly on the checkbox would select multiple rows this override makes the whole cell of the checkbox behave like the checkbox. This minimizes misclicks from the user. Signed-off-by: Dominik Csapak --- src/Toolkit.js | 7 +++++++ 1 file changed, 7 insertions(+) diff --git a/src/Toolkit.js b/src/Toolkit.js index f706036..8a27b26 100644 --- a/src/Toolkit.js +++ b/src/Toolkit.js @@ -493,6 +493,13 @@ Ext.define('Proxmox.validIdReOverride', { validIdRe: /^[a-z_][a-z0-9\-_@]*$/i, }); +// use whole checkbox cell to multiselect, not only the checkbox +Ext.define('Proxmox.selection.CheckboxModel', { + override: 'Ext.selection.CheckboxModel', + + checkSelector: '.x-grid-cell-row-checker', +}); + // force alert boxes to be rendered with an Error Icon // since Ext.Msg is an object and not a prototype, we need to override it // after the framework has been initiated