proxmox-mirrors/proxmox-widget-toolkit
1
0
Fork 1
mirror of https://git.proxmox.com/git/proxmox-widget-toolkit synced 2025-05-20 17:36:35 +00:00
Code Issues Actions Packages Projects Releases Wiki Activity

fix: gui: up/down arrow keys increment/decrement twice in Number field

Browse Source 
When the up or down arrow key on the keyboard was pressed while a
number text field (or any one descending from Ext.form.field.Spinner)
was selected, the up and down callbacks for that text fields KeyNav
were called twice. Therefore, the value in the text field would always
incorrectly increment/decrement by step * 2.

The problem was an overwrite for the onRender() method of the Spinner
class, which caused the callbacks for pressing an arrow key to be
registered for a second time. Simply not doing that in the overwritten
onRender() method fixes the problem.

The redundant declarations for spinUpEl and spinDownEl were removed as
well. Additionally, the 'mousewheel' event handler, registered in the
overwritten (but still executed) parent function, is unregistered now,
as it could lead to unintended side effects in browsers which still
implement this event.

Signed-off-by: Daniel Tschlatscher <d.tschlatscher@proxmox.com>
This commit is contained in:
Daniel Tschlatscher 2022-07-25 15:40:07 +02:00 committed by Dominik Csapak
parent 59551419b5
commit 94d84581c2
1 changed files with 4 additions and 22 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

26
src/Toolkit.js
View File

@ -464,35 +464,17 @@ Ext.define('Proxmox.form.field.Spinner', {
override: 'Ext.form.field.Spinner',
onRender: function() {
var me = this,
spinnerTrigger = me.getTrigger('spinner');
let me = this;
me.callParent();
// Init up/down arrow keys
if (me.keyNavEnabled) {
me.spinnerKeyNav = new Ext.util.KeyNav({
target: me.inputEl,
scope: me,
up: me.spinUp,
down: me.spinDown,
});
me.inputEl.on({
keyup: me.onInputElKeyUp,
scope: me,
});
}
// Init mouse wheel
if (me.mouseWheelEnabled) {
// Unlisten Ext generated listener ('mousewheel' is deprecated anyway)
me.mun(me.bodyEl, 'mousewheel', me.onMouseWheel, me);
me.mon(me.bodyEl, 'wheel', me.onMouseWheel, me);
}
// in v4 spinUpEl/spinDownEl were childEls, now they are children of the trigger.
// create references for compatibility
me.spinUpEl = spinnerTrigger.upEl;
me.spinDownEl = spinnerTrigger.downEl;
},
onMouseWheel: function(e) {