From 8d161ac19cf1c052450d56bf42b8a91db5447b50 Mon Sep 17 00:00:00 2001 From: Thomas Lamprecht Date: Fri, 1 Mar 2024 12:38:47 +0100 Subject: [PATCH] dns: update comment to avoid coupling to downstream dependency Not much of use, better comment why this exist, other products could change or new ones get added with new semantic used there too, so the previous comment would be guaranteed to become outdated rather sooner than later. Signed-off-by: Thomas Lamprecht --- src/node/DNSEdit.js | 3 ++- src/node/DNSView.js | 3 ++- 2 files changed, 4 insertions(+), 2 deletions(-) diff --git a/src/node/DNSEdit.js b/src/node/DNSEdit.js index c895d9b..5f8a20b 100644 --- a/src/node/DNSEdit.js +++ b/src/node/DNSEdit.js @@ -2,7 +2,8 @@ Ext.define('Proxmox.node.DNSEdit', { extend: 'Proxmox.window.Edit', alias: ['widget.proxmoxNodeDNSEdit'], - // pbs needs this set to true + // Some longer existing APIs use a brittle "replace whole config" style, you can set this option + // if the DNSEdit component is used in an API that has more modern, granular update semantics. deleteEmpty: false, initComponent: function() { diff --git a/src/node/DNSView.js b/src/node/DNSView.js index b57da85..34d9b95 100644 --- a/src/node/DNSView.js +++ b/src/node/DNSView.js @@ -2,7 +2,8 @@ Ext.define('Proxmox.node.DNSView', { extend: 'Proxmox.grid.ObjectGrid', alias: ['widget.proxmoxNodeDNSView'], - // pbs needs this set to true + // Some longer existing APIs use a brittle "replace whole config" style, you can set this option + // if the DNSView component is used in an API that has more modern, granular update semantics. deleteEmpty: false, initComponent: function() {