proxmox-mirrors/proxmox-widget-toolkit
1
0
Fork 1
mirror of https://git.proxmox.com/git/proxmox-widget-toolkit synced 2025-05-29 20:43:29 +00:00
Code Issues Actions Packages Projects Releases Wiki Activity

file browser: only disable button if not downloadable and add hint in tooltip

Browse Source 
To avoid to much layout jumping if the whole button disappears
(changes height of footer bar too), rather explain to the user the
why and what they can do instead.

Signed-off-by: Thomas Lamprecht <t.lamprecht@proxmox.com>
This commit is contained in:
Thomas Lamprecht 2022-05-15 10:37:43 +02:00
parent 9aa3d15708
commit 8812650c8b
1 changed files with 10 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

11
src/window/FileBrowser.js
View File

@ -130,7 +130,16 @@ Ext.define("Proxmox.window.FileBrowser", {
let downloadBtn = view.lookup('downloadBtn'); let downloadBtn = view.lookup('downloadBtn');
downloadBtn.setDisabled(!canDownload || enableMenu); downloadBtn.setDisabled(!canDownload || enableMenu);
downloadBtn.setHidden(!canDownload || enableMenu); downloadBtn.setHidden(canDownload && enableMenu);
let typeLabel = Proxmox.Schema.pxarFileTypes[data.type]?.label ?? Proxmox.Utils.unknownText;
let ttip = Ext.String.format(
gettext('File of type {0} cannot be downloaded directly, download a parent directory instead.'),
typeLabel,
);
if (!canDownload) { // ensure tooltip gets shown
downloadBtn.setStyle({ pointerEvents: 'all' });
}
downloadBtn.setTooltip(canDownload ? null : ttip);
let menuBtn = view.lookup('menuBtn'); let menuBtn = view.lookup('menuBtn');
menuBtn.setDisabled(!canDownload || !enableMenu); menuBtn.setDisabled(!canDownload || !enableMenu);