proxmox-mirrors/proxmox-widget-toolkit
1
0
Fork 1
mirror of https://git.proxmox.com/git/proxmox-widget-toolkit synced 2025-05-24 01:44:44 +00:00
Code Issues Actions Packages Projects Releases Wiki Activity

apt repositories: add production ready warnings for Ceph repositories

Browse Source 
Could've been done for the test repository already, but now that there
is a split between no-subscription and enterprise it becomes even more
relevant.

Reported-by: Thomas Lamprecht <t.lamprecht@proxmox.com>
Signed-off-by: Fiona Ebner <f.ebner@proxmox.com>
This commit is contained in:
Fiona Ebner 2023-06-16 15:42:35 +02:00 committed by Thomas Lamprecht
parent 01034bdb5f
commit 7d5201a32f
1 changed files with 39 additions and 9 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

48
src/node/APTRepositories.js
View File

@ -460,6 +460,11 @@ Ext.define('Proxmox.node.APTRepositories', {
let enterprise = vm.get('enterpriseRepo'); let enterprise = vm.get('enterpriseRepo');
let nosubscription = vm.get('noSubscriptionRepo'); let nosubscription = vm.get('noSubscriptionRepo');
let test = vm.get('testRepo'); let test = vm.get('testRepo');
let cephRepos = {
enterprise: vm.get('cephEnterpriseRepo'),
nosubscription: vm.get('cephNoSubscriptionRepo'),
test: vm.get('cephTestRepo'),
};
let wrongSuites = vm.get('suitesWarning'); let wrongSuites = vm.get('suitesWarning');
let mixedSuites = vm.get('mixedSuites'); let mixedSuites = vm.get('mixedSuites');
@ -483,17 +488,33 @@ Ext.define('Proxmox.node.APTRepositories', {
addWarn(gettext('Detected mixed suites before upgrade')); addWarn(gettext('Detected mixed suites before upgrade'));
} }
if (!activeSubscription && enterprise) { let productionReadyCheck = (repos, type, noSubAlternateName) => {
addWarn(gettext('The enterprise repository is enabled, but there is no active subscription!')); if (!activeSubscription && repos.enterprise) {
} addWarn(Ext.String.format(
gettext('The {0}enterprise repository is enabled, but there is no active subscription!'),
type,
));
}
if (nosubscription) { if (repos.nosubscription) {
addWarn(gettext('The no-subscription repository is not recommended for production use!')); addWarn(Ext.String.format(
} gettext('The {0}no-subscription{1} repository is not recommended for production use!'),
type,
noSubAlternateName,
));
}
if (test) { if (repos.test) {
addWarn(gettext('The test repository may pull in unstable updates and is not recommended for production use!')); addWarn(Ext.String.format(
} gettext('The {0}test repository may pull in unstable updates and is not recommended for production use!'),
type,
));
}
};
productionReadyCheck({ enterprise, nosubscription, test }, '', '');
// TODO drop alternate 'main' name when no longer relevant
productionReadyCheck(cephRepos, 'Ceph ', '/main');
if (errors.length > 0) { if (errors.length > 0) {
text = gettext('Fatal parsing error for at least one repository'); text = gettext('Fatal parsing error for at least one repository');
@ -518,6 +539,9 @@ Ext.define('Proxmox.node.APTRepositories', {
noSubscriptionRepo: '', noSubscriptionRepo: '',
enterpriseRepo: '', enterpriseRepo: '',
testRepo: '', testRepo: '',
cephEnterpriseRepo: '',
cephNoSubscriptionRepo: '',
cephTestRepo: '',
selectionenabled: false, selectionenabled: false,
state: {}, state: {},
}, },
@ -627,6 +651,12 @@ Ext.define('Proxmox.node.APTRepositories', {
vm.set('noSubscriptionRepo', status); vm.set('noSubscriptionRepo', status);
} else if (handle === 'test') { } else if (handle === 'test') {
vm.set('testRepo', status); vm.set('testRepo', status);
} else if (handle.match(/^ceph-[a-zA-Z]+-enterprise$/)) {
vm.set('cephEnterpriseRepo', status);
} else if (handle.match(/^ceph-[a-zA-Z]+-no-subscription$/)) {
vm.set('cephNoSubscriptionRepo', status);
} else if (handle.match(/^ceph-[a-zA-Z]+-test$/)) {
vm.set('cephTestRepo', status);
} }
me.getController().updateState(); me.getController().updateState();