From 736c3457a268c66d16502c7832bd94aed17d1bf3 Mon Sep 17 00:00:00 2001 From: Dominik Csapak Date: Fri, 31 Mar 2023 12:04:51 +0200 Subject: [PATCH] form: combo grid: use correct method to initialize the picker 'createPicker' does create the picker, but saves no reference to it in the owning field, Instead, 'getPicker' should be used for that, since that does all the necessary initialization, and actually assigns the created picker to the field's me.picker variable so that the pickers lifetime can be successfully tracked and enforced. Without this patch, we leak the picker being created every time a combo grid is created. Signed-off-by: Dominik Csapak --- src/form/ComboGrid.js | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/form/ComboGrid.js b/src/form/ComboGrid.js index 29c3d26..55dee7e 100644 --- a/src/form/ComboGrid.js +++ b/src/form/ComboGrid.js @@ -408,7 +408,7 @@ Ext.define('Proxmox.form.ComboGrid', { // Create the picker at an early stage, so it is available to store the previous selection if (!me.picker) { - me.createPicker(); + me.getPicker(); } me.mon(me.store, 'beforeload', function() {