From 64f65c027d0a60858c646deed67d7e5c383b2530 Mon Sep 17 00:00:00 2001 From: Lukas Wagner Date: Thu, 26 Jan 2023 11:47:10 +0100 Subject: [PATCH] repo view: replace non-clickable checkbox with icons From a usability view, having a checkbox that is not clickable is pretty misleading, especially if the visual style is exactly the same as in other places in the UI where the checkbox is functional. Signed-off-by: Lukas Wagner --- src/Utils.js | 2 ++ src/node/APTRepositories.js | 6 ++---- 2 files changed, 4 insertions(+), 4 deletions(-) diff --git a/src/Utils.js b/src/Utils.js index c9c00a9..7b7a83a 100644 --- a/src/Utils.js +++ b/src/Utils.js @@ -100,6 +100,8 @@ utilities: { return value; }, + renderEnabledIcon: enabled => ``, + language_array: function() { let data = [['__default__', Proxmox.Utils.render_language('')]]; Ext.Object.each(Proxmox.Utils.language_map, function(key, value) { diff --git a/src/node/APTRepositories.js b/src/node/APTRepositories.js index ce8f718..1fb627c 100644 --- a/src/node/APTRepositories.js +++ b/src/node/APTRepositories.js @@ -239,12 +239,10 @@ Ext.define('Proxmox.node.APTRepositoriesGrid', { columns: [ { - xtype: 'checkcolumn', header: gettext('Enabled'), dataIndex: 'Enabled', - listeners: { - beforecheckchange: () => false, // veto, we don't want to allow inline change - to subtle - }, + align: 'center', + renderer: Proxmox.Utils.renderEnabledIcon, width: 90, }, {